test(message_bus): parametrize makefile-failure cleanup test

Replace the two thin wrappers around _assert_makefile_failure_closes
with a single parametrized test so the unix and tcp cases are visible
in one place and the helper indirection goes away.

Author: agners

tests/test_message_bus.py

@@ -137,12 +137,21 @@ async def _boom(self: MessageBus) -> None:
         listener.close()
 
 
-def _assert_makefile_failure_closes(
+@pytest.mark.parametrize(
+    ("transport", "options", "family"),
+    [
+        ("unix", {"path": "/nope"}, socket.AF_UNIX),
+        ("tcp", {"host": "127.0.0.1", "port": "1"}, socket.AF_INET),
+    ],
+    ids=["unix", "tcp"],
+)
+def test_create_socket_for_transport_makefile_failure_closes_socket(
     monkeypatch: pytest.MonkeyPatch,
     transport: str,
     options: dict[str, str],
     family: int,
 ) -> None:
+    """A makefile() failure closes the socket before re-raising."""
     closed: list[int] = []
     real_close = socket.socket.close
 
@@ -162,24 +171,6 @@ def boom(self: socket.socket, *args: object, **kwargs: object) -> None:
     assert family in closed
 
 
-def test_create_socket_for_transport_unix_makefile_failure_closes_socket(
-    monkeypatch: pytest.MonkeyPatch,
-) -> None:
-    """A unix-transport makefile() failure closes the socket before re-raising."""
-    _assert_makefile_failure_closes(
-        monkeypatch, "unix", {"path": "/nope"}, socket.AF_UNIX
-    )
-
-
-def test_create_socket_for_transport_tcp_makefile_failure_closes_socket(
-    monkeypatch: pytest.MonkeyPatch,
-) -> None:
-    """A tcp-transport makefile() failure closes the socket before re-raising."""
-    _assert_makefile_failure_closes(
-        monkeypatch, "tcp", {"host": "127.0.0.1", "port": "1"}, socket.AF_INET
-    )
-
-
 def test_get_proxy_object_raises_when_proxy_object_class_missing() -> None:
     # ProxyObject defaults to None on BaseMessageBus, which is the condition
     # under test. Passing an explicit bus_address avoids depending on