Add range check for temperature and humidity#32
Open
henryk wants to merge 3 commits into
Open
Conversation
Adds a check to guard against physically impossible reported values. Temperatures below absolute zero, or humidity outside 0-100 %, likely are the result of an invalid received packet and should be disregarded (disregard entire packet, other data probably also wrong).
bdraco
requested changes
Jan 15, 2025
bdraco
left a comment
bdraco
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR.
Please add test coverage for these new cases.
Member
|
@henryk Do you expect to finish this PR? Thanks |
Author
|
Hi, yes, sorry. I couldn't immediately figure out how the test cases work and how I would even add a new one and then it slid off my radar due to work. I'll find some time this week. |
Contributor
|
If the problem you wanted to fix is home-assistant/core#161143, it should now have been fixed by #153 in a more specific way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to guard against physically impossible reported values. Temperatures below absolute zero, or humidity outside 0-100 %, likely are the result of an invalid received packet and should be disregarded (disregard entire packet, other data probably also wrong).