Skip to content

fix: move cadence summary to rate input#157

Open
David-T-Campos wants to merge 1 commit into
Blur009:devfrom
David-T-Campos:fix/cadence-rate-display
Open

fix: move cadence summary to rate input#157
David-T-Campos wants to merge 1 commit into
Blur009:devfrom
David-T-Campos:fix/cadence-rate-display

Conversation

@David-T-Campos
Copy link
Copy Markdown
Contributor

Summary

  • show the derived delay/cadence summary only while the Advanced cadence control is in Rate mode
  • keep Delay mode focused on the editable duration inputs without the extra cadence summary
  • make Advanced numeric cadence inputs transparent so browser default white input boxes do not show through
  • include minimal upstream validation hygiene fixes for the existing lint and Rust format failures on current dev

Related issue(s)

N/A

Change type

  • Bug fix
  • Documentation
  • Contributor workflow / CI
  • Refactor
  • Other

Validation

  • npm install passed; dependency install only, lockfile churn was discarded
  • npm run lint failed initially on existing upstream React lint errors, then passed after minimal fixes
  • npm run frontend:build passed; initial sandbox run hit Vite spawn permissions, rerun with normal permissions passed
  • cargo fmt check failed initially on existing upstream formatting, then passed after cargo fmt
  • cargo check locked passed
  • cargo test locked passed; 15 tests passed
  • Tauri no-bundle build passed and built the release executable

Checklist

  • I ran the relevant local validation commands and recorded them above
  • I kept the change focused and avoided unrelated refactors
  • I updated related documentation, templates, or contributor guidance when needed

@Blur009 Blur009 added this to the v3.5 milestone Apr 25, 2026
@Blur009
Copy link
Copy Markdown
Owner

Blur009 commented Apr 25, 2026

@David-T-Campos
Personally I have opted against doing this. I think it would be much more useful to have the mouse down and mouse up time next to the click duration % (on the left ofc). This way you could somewhat easily calculate your total time per click, but it also fits greatly into the ui while giving more context to Click duration.

The current implementation pushes the UI down which i try to avoid having panel sizes that change as its not too visually appealing in my opinion

@Blur009 Blur009 removed this from the v3.5 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants