test: improve collision resistance of temporary directories

shimomo · shimomo · commit 7978523b89f7 · 2025-08-30T02:30:45.000+09:00
diff --git a/tests/ProgramSaverTest.php b/tests/ProgramSaverTest.php
@@ -27,8 +27,10 @@ final class ProgramSaverTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        $this->tempDir = sys_get_temp_dir() . '/program_saver_test_' . uniqid();
-        mkdir($this->tempDir, 0755, true);
+        $this->tempDir = sys_get_temp_dir() . '/program_saver_test_' . bin2hex(random_bytes(8));
+        if (!mkdir($this->tempDir, 0755, true) && !is_dir($this->tempDir)) {
+            $this->fail('Failed to create temp dir: ' . $this->tempDir);
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,10 @@ final class ProgramSaverTest extends TestCase`
`27`	`27`	`protected function setUp(): void`
`28`	`28`	`{`
`29`	`29`	`parent::setUp();`
`30`		`- $this->tempDir = sys_get_temp_dir() . '/program_saver_test_' . uniqid();`
`31`		`- mkdir($this->tempDir, 0755, true);`
	`30`	`+ $this->tempDir = sys_get_temp_dir() . '/program_saver_test_' . bin2hex(random_bytes(8));`
	`31`	`+ if (!mkdir($this->tempDir, 0755, true) && !is_dir($this->tempDir)) {`
	`32`	`+ $this->fail('Failed to create temp dir: ' . $this->tempDir);`
	`33`	`+ }`
`32`	`34`	`}`
`33`	`35`
`34`	`36`	`/**`