Skip to content

ci: pin actions/checkout and shivammathur/setup-php action to specific commit #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shimomo merged 1 commit into from
Aug 31, 2025
Merged

ci: pin actions/checkout and shivammathur/setup-php action to specific commit #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:

steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4
with:
php-version: '8.4'

- name: Checkout Code
uses: actions/checkout@v5
uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Aug 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

push／rebase を行うジョブなので fetch-depth: 0 を必須指定してください

浅い履歴（デフォルト depth=1）のまま git pull --rebase を行うと失敗・コンフリクト発生時の復旧不可リスクがあります。

適用例:

-      - name: Checkout Code
-        uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+      - name: Checkout Code
+        uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+        with:
+          fetch-depth: 0
+          # （任意）運用上 gh-pages 固定が安全なら明示:
+          # ref: gh-pages
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
- name: Checkout Code
uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
with:
fetch-depth: 0
# （任意）運用上 gh-pages 固定が安全なら明示:
# ref: gh-pages
🤖 Prompt for AI Agents 
.github/workflows/cron.yml around line 23: the actions/checkout step is using
the default shallow clone which risks failing or making rebases unrecoverable;
update the checkout action to perform a full clone by adding a with:
fetch-depth: 0 block for that step so subsequent git pull --rebase or
push/rebase jobs have full history available and can recover from conflicts.

Copy link
Copy Markdown
Contributor Author

@shimomo shimomo Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

別のPRで対応します。

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimomo 了解しました。別のPRでの対応で問題ありません！

現在のPRはアクションの固定に集中しているので、fetch-depthの件は分けて対応するのが適切ですね。

🐰
o_o
( )
^^^


- name: Install base dependencies (without scraper)
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
- '8.4'
steps:
- name: Setup PHP ${{ matrix.php-version }}
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4
with:
php-version: ${{ matrix.php-version }}

- name: Checkout Repository
uses: actions/checkout@v5
uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493

- name: Install Dependencies
run: composer install --prefer-dist --no-interaction --no-progress --dev
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ jobs:
- '12.0'
steps:
- name: Setup PHP ${{ matrix.php-version }}
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@ec406be512d7077f68eed36e63f4d91bc006edc4
with:
php-version: ${{ matrix.php-version }}
coverage: pcov

- name: Checkout Repository
uses: actions/checkout@v5
uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493

- name: Require PHPUnit ${{ matrix.phpunit-version }}
run: composer require --dev phpunit/phpunit:^${{ matrix.phpunit-version }} --with-all-dependencies
Expand Down