bsp::grub2: Call updateConfigAllRecursive manually#93
Merged
Conversation
jkloetzke
reviewed
May 19, 2025
Required to make the checkout deterministic in all cases. Consider the following. If the bob workspace is clean (i.e. fresh checkout), the following sequence happens with regards to bsp::grub2: checkout_scm update_config bootstrap # checks out gnulib This leads to an as-is gnulib/build-aux/config.guess because it is checked out after update_config is run. If on the other hand dev/src/bsp/grub2 is not removed completely but bob still updates the workspace (e.g. after a git clean -dxf in the toplevel recipes directory), updateConfigAllRecursive will update the config files in the existing gnulib directory as well, resulting in a diff to the previous variant and therefore to an indeterministic SCM checkout. To solve this, set APPLY_UPDATE_CONFIG to "no" and call updateConfigAllRecursive manually after bootstrap.
reet-
force-pushed
the
grub2-deterministic
branch
from
c22c646 to
ddc6449
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to make the git checkout deterministic in all cases.
Consider the following. If the bob workspace is clean (i.e. fresh checkout), the following sequence happens with regards to bsp::grub2:
This leads to an as-is gnulib/build-aux/config.guess because it is checked out after update_config is run. If on the other hand dev/src/bsp/grub2 is not removed completely but bob still updates the workspace (e.g. after a git clean -dxf in the toplevel recipes directory), updateConfigAllRecursive will update the config files in the existing gnulib directory as well, resulting in a diff to the previous variant and therefore to an indeterministic SCM checkout.
To solve this, set APPLY_UPDATE_CONFIG to "no" and call updateConfigAllRecursive manually after bootstrap.