test: add tests for duplicate dependencies

Author: jkloetzke

test/unit/test_input_recipe.py

@@ -184,6 +184,27 @@ def testNestedCheckoutDep(self):
         self.cmpEntry(res[4], "e")
         self.cmpEntry(res[5], "f", checkoutDep=True)
 
+    def testNameAndDepends(self):
+        """A dependency must not use 'name' and 'depends' at the same time"""
+        deps = [
+            {
+                "name" : "a",
+                "depends" : [],
+            }
+        ]
+        with self.assertRaises(ParseError):
+            list(Recipe.Dependency.parseEntries(MagicMock(), deps))
+
+    def testNeitherNameNorDepends(self):
+        """A dependency must use 'name' or 'depends'"""
+        deps = [
+            {
+                "if" : "a",
+            }
+        ]
+        with self.assertRaises(ParseError):
+            list(Recipe.Dependency.parseEntries(MagicMock(), deps))
+
 
 class RecipeCommon:
 

test/unit/test_input_recipeset.py

@@ -877,6 +877,32 @@ def testPackageDepends(self):
         self.assertEqual(p.getPackageStep().getArguments()[2].getPackage().getName(),
                          "lib2")
 
+    def testDuplicateDep(self):
+        """Dependencies must only be named once"""
+        self.writeRecipe("root", """\
+            root: True
+            depends: [a, a]
+            """)
+        self.writeRecipe("a", "")
+
+        packages = self.generate()
+        self.assertRaises(ParseError, packages.getRootPackage)
+
+    def testDuplicateDepWithClass(self):
+        """Dependencies must only be named once"""
+        self.writeRecipe("root", """\
+            root: True
+            inherit: [cls]
+            depends: [a]
+            """)
+        self.writeClass("cls", """\
+            depends: [a]
+            """)
+        self.writeRecipe("a", "")
+
+        packages = self.generate()
+        self.assertRaises(ParseError, packages.getRootPackage)
+
 class TestDependencyEnv(RecipesTmp, TestCase):
     """Tests related to "environment" block in dependencies"""