Fix exclude-file-types for known files#465
Merged
Merged
Conversation
kehoecj
requested changes
May 1, 2026
Collaborator
kehoecj
left a comment
There was a problem hiding this comment.
Thanks for the PR! Code looks good. Testing confirms this change has addressed the issue. A few things before we can merge:
- Create a changelog entry under [Unreleased] for this bug fix
- You'll need to generate and commit the new linguist data. I just created #466 so MR authors won't have to do it on future submissions but you'll have to run the below commands to get the job to pass for now:
go generate ./pkg/filetype/...
git add pkg/filetype/known_files_gen.go
git commit -m "chore: regenerate known files from Linguist"
Contributor
Author
|
Addressed, thanks.
Let me know if this needs more fixes or additions. |
kehoecj
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary:
Fixes #456
Summary
--exclude-file-typesafter resolving file type.gitconfigandjustfileby resolved typeTest
go test ./pkg/finder -run "Test_fsFinderExcludeFileTypes|Test_fsFinderKnownFiles|Test_fsFinderLinguistKnownFiles"Please let me know if there are any further fixes or ammends to make.