Legacy mode fix: release reserved increment_id after cancel/submit to…#1964
Open
garmashdev wants to merge 1 commit into
Open
Legacy mode fix: release reserved increment_id after cancel/submit to…#1964garmashdev wants to merge 1 commit into
garmashdev wants to merge 1 commit into
Conversation
… stop "Order was created" popup
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Generated by 🚫 dangerJS |
pejter
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
M2_CANCEL_FAILED_PAYMENT_ORDERS_INSTEAD_OF_DELETINGhit a loop: after a failed payment the canceled order keeps its increment_id, the admin session quote still carries the samebolt_reserved_order_id, and the next attempt trips doesOrderExist → popup "Order was created. Please reload the page and try again".Fix
Helper/Order::dispatchPostCheckoutEvents- null bolt_reserved_order_id + reserved_order_id on the parent quote after checkout_submit_all_after dispatch (so observers still see the id).elper/Order::cancelFailedPaymentOrder- same null-out after cancellation (guarded by if ($parentQuote)).Fixes: (link ticket)
#changelog Legacy mode fix: release reserved increment_id after cancel/submit to…
Type of change
How Has This Been Tested?
Please validate that you have tested your change in at least one of the following areas:
For PR Reviewer
Checklist: