Fix search issue for words inside Guillemets (« ») without spaces#5475
Merged
ssddanbrown merged 1 commit intoBookStackApp:developmentfrom Feb 14, 2025
inv-hareesh:development
Merged
Fix search issue for words inside Guillemets (« ») without spaces#5475ssddanbrown merged 1 commit intoBookStackApp:developmentfrom inv-hareesh:development
ssddanbrown merged 1 commit intoBookStackApp:developmentfrom
inv-hareesh:development
Conversation
Member
|
Thanks @inv-hareesh, now merged for next feature release. |
This was referenced Feb 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where words enclosed in Guillemets (« ») were not indexed correctly for search when there was no space after the opening quote. The search engine was not recognizing such words as separate terms, leading to failed search results.
The fix involves updating the list of delimiter characters in SearchIndex::$delimiters to include Guillemets (« and »), ensuring that words within them are properly tokenized and indexed.