Skip to content

Commit 1aaba74

Browse files
committed
refactor: Improve sendWakatimeHeartBeat.
1 parent 6fe6794 commit 1aaba74

2 files changed

Lines changed: 22 additions & 38 deletions

File tree

browser/components/CodeEditor.js

Lines changed: 21 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,11 @@ export default class CodeEditor extends React.Component {
120120
const { storageKey, noteKey } = this.props
121121
const storage = findStorage(storageKey)
122122
if (storage)
123-
sendWakatimeHeartBeat(
124-
storage.path,
125-
noteKey,
126-
storage.name,
127-
false,
128-
false,
129-
true
130-
)
123+
sendWakatimeHeartBeat(storage.path, noteKey, storage.name, {
124+
isWrite: false,
125+
hasFileChanges: false,
126+
isFileChange: true
127+
})
131128
}
132129

133130
handleSearch(msg) {
@@ -813,25 +810,17 @@ export default class CodeEditor extends React.Component {
813810
const storage = findStorage(storageKey)
814811
if (this.props.onChange) {
815812
this.props.onChange(editor)
816-
if (storage)
817-
sendWakatimeHeartBeat(
818-
storage.path,
819-
noteKey,
820-
storage.name,
821-
true,
822-
true,
823-
false
824-
)
825-
} else {
826-
if (storage)
827-
sendWakatimeHeartBeat(
828-
storage.path,
829-
noteKey,
830-
storage.name,
831-
false,
832-
false,
833-
false
834-
)
813+
}
814+
815+
const isWrite = !!this.props.onChange
816+
const hasFileChanges = isWrite
817+
818+
if (storage) {
819+
sendWakatimeHeartBeat(storage.path, noteKey, storage.name, {
820+
isWrite,
821+
hasFileChanges,
822+
isFileChange: false
823+
})
835824
}
836825
}
837826

@@ -965,14 +954,11 @@ export default class CodeEditor extends React.Component {
965954
const { storageKey, noteKey } = this.props
966955
const storage = findStorage(storageKey)
967956
if (storage)
968-
sendWakatimeHeartBeat(
969-
storage.path,
970-
noteKey,
971-
storage.name,
972-
false,
973-
false,
974-
true
975-
)
957+
sendWakatimeHeartBeat(storage.path, noteKey, storage.name, {
958+
isWrite: false,
959+
hasFileChanges: false,
960+
isFileChange: true
961+
})
976962
}
977963

978964
setValue(value) {

browser/lib/wakatime-plugin.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ function sendWakatimeHeartBeat(
77
storagePath,
88
noteKey,
99
storageName,
10-
isWrite,
11-
hasFileChanges,
12-
isFileChange
10+
{ isWrite, hasFileChanges, isFileChange }
1311
) {
1412
if (
1513
config.get().wakatime.isActive &&

0 commit comments

Comments
 (0)