Skip to content

Fix Python binding build for pip/uv install #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jloganolson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Python binding build for pip/uv install #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ add_executable(battery_state_subscriber example/low_level/battery_state_subscrib



include_directories(BEFORE $(PROJECT_SOURCE_DIR)/include)
include_directories(BEFORE ${PROJECT_SOURCE_DIR}/include)

if(BUILD_PYTHON_BINDING)
find_package(Python3 REQUIRED COMPONENTS Interpreter Development.Module)
Expand All @@ -44,6 +44,7 @@ if(BUILD_PYTHON_BINDING)
find_package(pybind11 CONFIG REQUIRED)

python3_add_library(booster_robotics_sdk_python MODULE python/binding.cpp WITH_SOABI)
target_link_libraries(booster_robotics_sdk_python PRIVATE pybind11::headers)

target_compile_definitions(booster_robotics_sdk_python PRIVATE VERSION_INFO=${PROJECT_VERSION})

Expand All @@ -55,10 +56,10 @@ if(BUILD_PYTHON_BINDING)
add_custom_command(
TARGET booster_robotics_sdk_python
POST_BUILD
COMMAND PYTHONPATH=${CMAKE_SOURCE_DIR}/build:/${PYTHONPATH} pybind11-stubgen -o ${CMAKE_SOURCE_DIR}/build booster_robotics_sdk_python
COMMAND ${CMAKE_COMMAND} -E env "PYTHONPATH=${CMAKE_CURRENT_BINARY_DIR}" pybind11-stubgen -o ${CMAKE_CURRENT_BINARY_DIR} booster_robotics_sdk_python
)

install(TARGETS booster_robotics_sdk_python LIBRARY DESTINATION ${PYTHON_SITE_PACKAGES})
install(FILES ${CMAKE_SOURCE_DIR}/build/booster_robotics_sdk_python.pyi DESTINATION ${PYTHON_SITE_PACKAGES})
install(TARGETS booster_robotics_sdk_python LIBRARY DESTINATION ${SKBUILD_PLATLIB_DIR})
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/booster_robotics_sdk_python.pyi DESTINATION ${SKBUILD_PLATLIB_DIR} OPTIONAL)
endif()

3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["scikit-build-core>=0.3.3", "pybind11"]
requires = ["scikit-build-core>=0.3.3", "pybind11", "pybind11-stubgen"]
build-backend = "scikit_build_core.build"


Expand Down Expand Up @@ -30,6 +30,7 @@ test = ["pytest"]

[tool.scikit-build]
wheel.expand-macos-universal-tags = true
cmake.define.BUILD_PYTHON_BINDING = "ON"


[tool.pytest.ini_options]
Expand Down