Skip to content

v2 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosampler merged 8 commits into from
Oct 27, 2025
Merged

v2 #18

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c46a90f
dependencies bump
nicosampler Oct 2, 2025
c9f245e
make peerDependencies more flexible
nicosampler Oct 6, 2025
58d713e
make peerDependencies more flexible
nicosampler Oct 6, 2025
34de8d4
sdkv3 dependency
nicosampler Oct 6, 2025
99eea9d
v2: wip
nicosampler Oct 20, 2025
f3a4e9c
fix more tests
nicosampler Oct 27, 2025
a05420c
update pnpm-lock
nicosampler Oct 27, 2025
46bb1a2
package version bump
nicosampler Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
"registry": "https://registry.npmjs.org/"
},
"peerDependencies": {
"@tanstack/react-query": "^5.87.4",
"react": "^19.1.1",
"react-dom": "^19.1.1"
"@tanstack/react-query": "^5",
"react": "^18 || ^19",
"react-dom": "^18 || ^19"

Copilot AI Oct 27, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependency range for @tanstack/react-query is too broad (^5) and may include breaking changes across minor versions. Consider using a more specific range like '^5.0.0' or document the minimum tested version to ensure compatibility.

Suggested change
"react-dom": "^18 || ^19"
"react-dom": "^18.0.0 || ^19.0.0"

Copilot uses AI. Check for mistakes.
},
"devDependencies": {
"@biomejs/biome": "2.2.4",
Expand Down Expand Up @@ -80,9 +80,7 @@
},
"dependencies": {
"@uniswap/permit2-sdk": "^1.4.0",
"@uniswap/router-sdk": "^2.0.4",
"@uniswap/sdk-core": "^7.7.2",
"@uniswap/universal-router-sdk": "^4.19.7",
"@uniswap/v3-sdk": "^3.25.2",
"@uniswap/v4-sdk": "^1.21.4",
"ethers": "^5.7.2",
Expand All @@ -96,7 +94,9 @@
"jsbi": "3.2.5"
},
"peerDependencyRules": {
"ignoreMissing": ["@testing-library/dom"]
"ignoreMissing": [
"@testing-library/dom"
]
}
}
}
319 changes: 155 additions & 164 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

312 changes: 147 additions & 165 deletions src/core/uniDevKitV4.ts
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 0 additions & 14 deletions src/test/core/uniDevKitV4.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ describe('UniDevKitV4', () => {
sdk = new UniDevKitV4(config)
})

it('should initialize with correct config', () => {
expect(sdk.getChainId()).toBe(config.chainId)
expect(sdk.getContracts()).toEqual(config.contracts)
})

it('should get contract address', () => {
expect(sdk.getContractAddress('quoter')).toBe(config.contracts.quoter)
})
Expand All @@ -43,14 +38,5 @@ describe('UniDevKitV4', () => {
rpcUrl: 'https://base-rpc.com',
}
sdk = new UniDevKitV4(newConfig)
expect(sdk.getChainId()).toBe(newConfig.chainId)
})

it('should create client with custom native currency', () => {
const customConfig: UniDevKitV4Config = {
...config,
}
const customSdk = new UniDevKitV4(customConfig)
expect(customSdk.getClient()).toBeDefined()
})
})
Loading
Loading