Feature: Configure backup retention

Author: BornToBeRoot

Source/NETworkManager.Localization/Resources/Strings.Designer.cs

@@ -3951,4 +3951,14 @@ If you click Cancel, the profile file will remain unencrypted.</value>
   <data name="CouldNotParseX" xml:space="preserve">
     <value>Could not parse "{0}".</value>
   </data>
+  <data name="MaximumNumberOfBackups" xml:space="preserve">
+    <value>Maximum Number of Backups</value>
+  </data>
+  <data name="HelpMessage_SettingsMaximumNumberOfBackups" xml:space="preserve">
+    <value>The number of settings backups that are retained before the oldest one is deleted.
+
+An automatic backup is only created once a day, before saving a change.
+
+The value 0 disables the creation of automatic backups. Backups that have already been created are not deleted.</value>
+  </data>
 </root>

Source/NETworkManager.Localization/Resources/Strings.resx

@@ -527,7 +527,6 @@ private static void RemoveIPAddressFromNetworkInterface(NetworkInterfaceConfig c
 
     #endregion
 
-
     #region Events
 
     /// <summary>

Source/NETworkManager.Models/Network/NetworkInterface.cs

@@ -46,9 +46,6 @@ public static class GlobalStaticConfiguration
     public static string ZipFileExtensionFilter => "ZIP Archive (*.zip)|*.zip";
     public static string XmlFileExtensionFilter => "XML-File (*.xml)|*.xml";
 
-    // Backup settings
-    public static int Backup_MaximumNumberOfBackups => 10;
-
     #endregion
 
     #region Default settings
@@ -74,18 +71,21 @@ public static class GlobalStaticConfiguration
     public static bool Status_ShowWindowOnNetworkChange => true;
     public static int Status_WindowCloseTime => 10;
 
-    // HotKey
+    // Settings: HotKey
     public static int HotKey_ShowWindowKey => 79;
     public static int HotKey_ShowWindowModifier => 3;
 
-    // Update
+    // Settings: Update
     public static bool Update_CheckForUpdatesAtStartup => true;
-
     public static bool Update_CheckForPreReleases => false;
-
-    // Experimental
     public static bool Experimental_EnableExperimentalFeatures => false;
 
+    // Settings: Profiles
+    public static int Profiles_MaximumNumberOfBackups => 10;
+
+    // Settings: Settings
+    public static int Settings_MaximumNumberOfBackups => 10;
+    
     // Application: Dashboard
     public static string Dashboard_PublicIPv4Address => "1.1.1.1";
     public static string Dashboard_PublicIPv6Address => "2606:4700:4700::1111";

Source/NETworkManager.Settings/GlobalStaticConfiguration.cs

@@ -582,6 +582,37 @@ public string Profiles_LastSelected
         }
     }
 
+    private int _profiles_MaximumNumberOfBackups = GlobalStaticConfiguration.Profiles_MaximumNumberOfBackups;
+
+    public int Profiles_MaximumNumberOfBackups
+    {
+        get => _profiles_MaximumNumberOfBackups;
+        set
+        {
+            if (value == _profiles_MaximumNumberOfBackups)
+                return;
+
+            _profiles_MaximumNumberOfBackups = value;
+            OnPropertyChanged();
+        }
+    }
+
+    // Settings
+    private int _settings_MaximumNumberOfBackups = GlobalStaticConfiguration.Settings_MaximumNumberOfBackups;
+
+    public int Settings_MaximumNumberOfBackups
+    {
+        get => _settings_MaximumNumberOfBackups;
+        set
+        {
+            if (value == _settings_MaximumNumberOfBackups)
+                return;
+
+            _settings_MaximumNumberOfBackups = value;
+            OnPropertyChanged();
+        }
+    }
+
     #endregion
 
     #region Others

Source/NETworkManager.Settings/SettingsInfo.cs

@@ -265,6 +265,16 @@ private static void SerializeToFile(string filePath)
     /// called as part of a daily maintenance routine.</remarks>
     private static void CreateDailyBackupIfNeeded()
     {
+        var maxBackups = Current.Settings_MaximumNumberOfBackups;
+
+        // Check if backups are disabled
+        if (maxBackups == 0)
+        {
+            Log.Debug("Daily backups are disabled. Skipping backup creation...");
+
+            return;
+        }
+
         var currentDate = DateTime.Now.Date;
 
         if (Current.LastBackup < currentDate)
@@ -284,7 +294,7 @@ private static void CreateDailyBackupIfNeeded()
             // Cleanup old backups
             CleanupBackups(GetSettingsBackupFolderLocation(),
                 GetSettingsFileName(),
-                GlobalStaticConfiguration.Backup_MaximumNumberOfBackups);
+                maxBackups);
 
             Current.LastBackup = currentDate;
         }

Source/NETworkManager.Settings/SettingsManager.cs

@@ -22,6 +22,8 @@ public class SettingsProfilesViewModel : ViewModelBase
 
     public Action CloseAction { get; set; }
 
+    private readonly bool _isLoading;
+
     private string _location;
 
     public string Location
@@ -67,24 +69,46 @@ public ProfileFileInfo SelectedProfileFile
         }
     }
 
+    private int _maximumNumberOfBackups;
+
+    public int MaximumNumberOfBackups
+    {
+        get => _maximumNumberOfBackups;
+        set
+        {
+            if (value == _maximumNumberOfBackups)
+                return;
+
+            if (!_isLoading)
+                SettingsManager.Current.Profiles_MaximumNumberOfBackups = value;
+
+            _maximumNumberOfBackups = value;
+            OnPropertyChanged();
+        }
+    }
     #endregion
 
     #region Constructor, LoadSettings
 
     public SettingsProfilesViewModel()
     {
+        _isLoading = true;
+
         ProfileFiles = new CollectionViewSource { Source = ProfileManager.ProfileFiles }.View;
         ProfileFiles.SortDescriptions.Add(
             new SortDescription(nameof(ProfileFileInfo.Name), ListSortDirection.Ascending));
 
         SelectedProfileFile = ProfileFiles.Cast<ProfileFileInfo>().FirstOrDefault();
 
         LoadSettings();
+
+        _isLoading = false;
     }
 
     private void LoadSettings()
     {
         Location = ProfileManager.GetProfilesFolderLocation();
+        MaximumNumberOfBackups = SettingsManager.Current.Profiles_MaximumNumberOfBackups;
     }
 
     #endregion

Source/NETworkManager/ViewModels/SettingsProfilesViewModel.cs

@@ -1,8 +1,6 @@
-using MahApps.Metro.SimpleChildWindow;
-using NETworkManager.Localization.Resources;
+using NETworkManager.Localization.Resources;
 using NETworkManager.Settings;
 using NETworkManager.Utilities;
-using NETworkManager.Views;
 using System;
 using System.Diagnostics;
 using System.Threading.Tasks;
@@ -16,6 +14,8 @@ public class SettingsSettingsViewModel : ViewModelBase
     #region Variables
     public Action CloseAction { get; set; }
 
+    private readonly bool _isLoading;
+
     private string _location;
 
     public string Location
@@ -30,18 +30,42 @@ public string Location
             OnPropertyChanged();
         }
     }
+
+    private int _maximumNumberOfBackups;
+
+    public int MaximumNumberOfBackups
+    {
+        get => _maximumNumberOfBackups;
+        set
+        {
+            if (value == _maximumNumberOfBackups)
+                return;
+
+            if (!_isLoading)
+                SettingsManager.Current.Settings_MaximumNumberOfBackups = value;
+
+            _maximumNumberOfBackups = value;
+            OnPropertyChanged();
+        }
+    }
+
     #endregion
 
     #region Constructor, LoadSettings
 
     public SettingsSettingsViewModel()
     {
+        _isLoading = true;
+
         LoadSettings();
+
+        _isLoading = false;
     }
 
     private void LoadSettings()
     {
         Location = SettingsManager.GetSettingsFolderLocation();
+        MaximumNumberOfBackups = SettingsManager.Current.Settings_MaximumNumberOfBackups;
     }
 
     #endregion

Source/NETworkManager/ViewModels/SettingsSettingsViewModel.cs

@@ -3,6 +3,7 @@
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
              xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+             xmlns:mah="http://metro.mahapps.com/winfx/xaml/controls"
              xmlns:iconPacks="http://metro.mahapps.com/winfx/xaml/iconpacks"
              xmlns:viewModels="clr-namespace:NETworkManager.ViewModels"
              xmlns:localization="clr-namespace:NETworkManager.Localization.Resources;assembly=NETworkManager.Localization"
@@ -30,8 +31,23 @@
                 </Grid>
             </Button.Content>
         </Button>
+        <TextBlock Style="{StaticResource HeaderTextBlock}" Text="{x:Static localization:Strings.Backup}" />
+        <StackPanel Orientation="Horizontal" Margin="0,0,0,20">
+            <TextBlock Text="{x:Static localization:Strings.MaximumNumberOfBackups}"
+                       Style="{StaticResource CenterTextBlock}"
+                       Margin="0,0,0,10" />
+            <mah:NumericUpDown Value="{Binding MaximumNumberOfBackups}" Minimum="0" Maximum="100" Interval="1"/>
+            <Rectangle Width="24" Height="24"
+                       ToolTip="{x:Static localization:Strings.HelpMessage_SettingsMaximumNumberOfBackups}"
+                       Style="{StaticResource HelpImageRectangle}" Margin="10,0,0,0">
+                <Rectangle.Resources>
+                    <Style TargetType="{x:Type ToolTip}" BasedOn="{StaticResource HelpToolTip}" />
+                </Rectangle.Resources>
+            </Rectangle>
+        </StackPanel>
         <TextBlock Style="{StaticResource HeaderTextBlock}" Text="{x:Static localization:Strings.Reset}" />
         <Button Content="{x:Static localization:Strings.Reset}" Command="{Binding ResetSettingsCommand}"
-                IsEnabled="{Binding SettingsExists}" Style="{StaticResource DefaultButton}" HorizontalAlignment="Left" />
+                Style="{StaticResource DefaultButton}" HorizontalAlignment="Left" 
+                />
     </StackPanel>
 </UserControl>