Skip to content

Commit 9802233

Browse files
committed
Merge glibc arm64 and Windows arm64 TS workflow into reusable workflow
1 parent a8cd564 commit 9802233

2 files changed

Lines changed: 12 additions & 102 deletions

File tree

.github/workflows/build-typescript-release-win-arm64.yaml

Lines changed: 0 additions & 88 deletions
This file was deleted.

.github/workflows/build-typescript-release.reusable.yaml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_call: {}
55
push:
66
branches:
7-
- ts-release
7+
- sam/win-arm64-ts
88

99
concurrency:
1010
# suffix is important to prevent a concurrency deadlock with the calling workflow
@@ -25,23 +25,21 @@ jobs:
2525
fail-fast: false
2626
matrix:
2727
_:
28-
- target: aarch64-apple-darwin
29-
host: macos-14
30-
node_build: pnpm build:napi-release --target aarch64-apple-darwin
31-
3228
- target: aarch64-unknown-linux-gnu
33-
# Do not use -latest, since it uses a different glibc version!
34-
host: ubuntu-22.04-arm
35-
# from https://github.com/PyO3/maturin-action?tab=readme-ov-file#manylinux-docker-container
36-
# need a new version of manylinux to build crates on arm64-linux
37-
# Note: update (aaron): this container doesnt work due to this error with ring:
38-
# https://github.com/briansmith/ring/issues/1728
39-
# So now we use ubuntu-arm, but glibc is too high, so we have to figure out container approach later.
40-
# potential fix in https://github.com/apache/opendal/issues/5483
41-
# container: ghcr.io/rust-cross/manylinux_2_28-cross:aarch64
29+
host: ubuntu-24.04-arm
30+
# Target glibc 2.17. This is the oldest glibc we can practically support.
31+
# Note that ubuntu-22.04-arm has glibc 2.35, but our users need older glibc.
32+
# See https://github.com/BoundaryML/baml/issues/2736
33+
container: ghcr.io/rust-cross/manylinux2014-cross:aarch64
34+
before: |
35+
echo "CFLAGS_aarch64_unknown_linux_gnu=-D__ARM_ARCH=8" >> "$GITHUB_ENV"
4236
node_build: pnpm build:napi-release --target aarch64-unknown-linux-gnu
4337
cargo_args: -p baml-typescript-ffi -p baml-python-ffi
4438

39+
- target: aarch64-apple-darwin
40+
host: macos-14
41+
node_build: pnpm build:napi-release --target aarch64-apple-darwin
42+
4543
- target: x86_64-apple-darwin
4644
host: macos-14
4745
node_build: pnpm build:napi-release --target x86_64-apple-darwin

0 commit comments

Comments
 (0)