mise protoc gen go

Author: sxlijin

.github/actions/setup-all/action.yml

@@ -77,10 +77,6 @@ inputs:
     description: 'Go version to install'
     required: false
     default: '1.24'
-  go-install-protoc-gen-go:
-    description: 'Install protoc-gen-go'
-    required: false
-    default: 'true'
   go-install-goimports:
     description: 'Install goimports'
     required: false

.github/actions/setup-go/action.yml

@@ -6,10 +6,6 @@ inputs:
     description: "Go version to install"
     required: false
     default: "1.23.11"
-  install-protoc-gen-go:
-    description: "Install protoc-gen-go"
-    required: false
-    default: "true"
   cache:
     description: "Enable Go module caching"
     required: false
@@ -53,12 +49,6 @@ runs:
         fi
       shell: bash
 
-    - name: Install protoc-gen-go
-      if: inputs.install-protoc-gen-go == 'true'
-      # locked to match the version in mise.toml
-      run: go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.36.6
-      shell: bash
-
     - name: Install goimports
       if: inputs.install-goimports == 'true'
       run: go install golang.org/x/tools/cmd/goimports@latest

.github/workflows/build-cli-release.reusable.yaml

@@ -14,7 +14,7 @@ on:
         required: false
   push:
     branches:
-      - protoc-fix
+      - sam/mise-protoc-gen-go
 env:
   MACOSX_DEPLOYMENT_TARGET: "10.13"
   # Turbo remote caching
@@ -82,18 +82,10 @@ jobs:
       - name: Setup Go
         uses: ./.github/actions/setup-go
 
-      - name: Install protoc-gen-go into .cargo/bin
-        shell: bash
-        run: |
-          # The cross-compile environment sanitizes the PATH, so we install the plugin
-          # directly into a directory that is guaranteed to be in the PATH for cargo.
-          # We also create a symlink from the go/bin to the cargo/bin for consistency.
-          mkdir -p .cargo/bin
-          go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
-          go install golang.org/x/tools/cmd/goimports@latest
-          cp "$HOME/go/bin/protoc-gen-go" ".cargo/bin/"
-          echo "Installed protoc-gen-go into .cargo/bin:"
-          ls -la .cargo/bin
+
+      - uses: jdx/mise-action@v2
+        with:
+          install_args: "protoc-gen-go"
 
       - name: Test protoc-gen-go availability
         id: protoc_gen_go_setup

engine/language_client_cffi/build.rs

@@ -361,6 +361,33 @@ fn main() -> std::io::Result<()> {
         // Allow overriding the protoc-gen-go plugin path
         if let Ok(path) = std::env::var("PROTOC_GEN_GO_PATH") {
             protoc.plugin(&path);
+        } else {
+            // Try to find protoc-gen-go using mise
+            match std::process::Command::new("mise")
+                .args(["which", "protoc-gen-go"])
+                .output()
+            {
+                Ok(output) if output.status.success() => {
+                    let path = String::from_utf8_lossy(&output.stdout);
+                    if !path.is_empty() {
+                        eprintln!("Using protoc-gen-go from mise: {}", path);
+                        protoc.plugin(path.trim());
+                    } else {
+                        eprintln!("protoc-gen-go fallback: mise which returned empty path, relying on PATH");
+                    }
+                }
+                Ok(_) => {
+                    eprintln!(
+                        "protoc-gen-go fallback: mise which protoc-gen-go failed, relying on PATH"
+                    );
+                }
+                Err(e) => {
+                    eprintln!(
+                        "protoc-gen-go fallback: mise command failed ({}), relying on PATH",
+                        e
+                    );
+                }
+            }
         }
 
         protoc

mise.toml

@@ -16,7 +16,7 @@ node = "lts"     # For pnpm
 
 # Go tools
 # locked to match the version in .github/actions/setup-go/action.yml
-"go:google.golang.org/protobuf/cmd/protoc-gen-go" = "v1.36.6"
+"protoc-gen-go" = "v1.34.1"
 "go:golang.org/x/tools/cmd/goimports" = "latest"
 "go:github.com/chrishrb/go-grip" = "latest"
 
@@ -33,4 +33,4 @@ node = "lts"     # For pnpm
 
 [settings]
 experimental = true
-# idiomatic_version_file_enable_tools = ["node", "python", "ruby", "go"]
+# idiomatic_version_file_enable_tools = ["node", "python", "ruby", "go"]