Add postmon as new provider#266
Open
RodriAndreotti wants to merge 10 commits intoBrasilAPI:masterfrom
Open
Conversation
lucianopf
reviewed
Feb 21, 2024
lucianopf
reviewed
Feb 21, 2024
RodriAndreotti
force-pushed
the
add_new_provider
branch
from
53e0833 to
08a911d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acredito que consegui acertar as arestas, todos os testes mockados estão funcionando
Porém os testes do e2e está zoado, devido ao serviço do correios que não conseguimos mais consultar.
Adicionei também uma tratativa para evitar falsos positivos no correios-alt, visto que o php que chamamos consulta qualquer coisa que esteja dentro do endereço, mesmo que ele não seja o cep, por exemplo 99999999 que não é um cep existente, porém tem uma observação no endereço, o qual fazia com que ele fosse retornado do correios-alt