[tests] Cleanup test imports and move deprecated import tests to test_api

Author: Breakthrough

tests/test_api.py

@@ -142,3 +142,28 @@ def on_new_scene(frame_img: numpy.ndarray, frame_num: int):
     scene_manager = SceneManager()
     scene_manager.add_detector(ContentDetector())
     scene_manager.detect_scenes(video=video, duration=total_frames, callback=on_new_scene)
+
+
+# TODO(v0.8): Remove this test when these deprecated modules are removed from the codebase.
+def test_deprecated_modules_emits_warning_on_import():
+    import importlib
+
+    import pytest
+
+    SCENE_DETECTOR_WARNING = (
+        "The `scene_detector` submodule is deprecated, import from the base package instead."
+    )
+    with pytest.warns(DeprecationWarning, match=SCENE_DETECTOR_WARNING):
+        importlib.import_module("scenedetect.scene_detector")
+
+    FRAME_TIMECODE_WARNING = (
+        "The `frame_timecode` submodule is deprecated, import from the base package instead."
+    )
+    with pytest.warns(DeprecationWarning, match=FRAME_TIMECODE_WARNING):
+        importlib.import_module("scenedetect.frame_timecode")
+
+    VIDEO_SPLITTER_WARNING = (
+        "The `video_splitter` submodule is deprecated, import from the base package instead."
+    )
+    with pytest.warns(DeprecationWarning, match=VIDEO_SPLITTER_WARNING):
+        importlib.import_module("scenedetect.video_splitter")

tests/test_cli.py

@@ -12,37 +12,35 @@
 
 import os
 import subprocess
-import typing as ty
-from pathlib import Path
-
-import cv2
-import numpy as np
-import pytest
-
-import scenedetect
-from scenedetect.output import is_ffmpeg_available, is_mkvmerge_available
 
 # These tests validate that the CLI itself functions correctly, mainly based on the return
 # return code from the process. We do not yet check for correctness of the output, just a
 # successful invocation of the command (i.e. no exceptions/errors).
-
 # TODO: Add some basic correctness tests to validate the output (just look for the
 # last expected log message or extract # of scenes). Might need to refactor the test cases
 # since we need to calculate the output file names for commands that write to disk.
-
 # TODO: Define error/exit codes explicitly. Right now these tests only verify that the
 # exit code is zero or nonzero.
-
 # TODO: These tests are very expensive since they spin up new Python interpreters.
 # Move most of these test cases (e.g. argument validation) to ones that interface directly
 # with the scenedetect._cli module. Click also supports unit testing directly, so we should
 # probably use that instead of spinning up new subprocesses for each run of the controller.
 # That will also allow splitting up the validation of argument parsing logic from the controller
 # logic by creating a CLI context with the desired parameters.
-
 # TODO: Missing tests for --min-scene-len and --drop-short-scenes.
+import sys
+import typing as ty
+from pathlib import Path
+
+import cv2
+import numpy as np
+import pytest
+
+import scenedetect
+from scenedetect.output import is_ffmpeg_available, is_mkvmerge_available
+
+SCENEDETECT_CMD = sys.executable + " -m scenedetect"
 
-SCENEDETECT_CMD = "python -m scenedetect"
 ALL_DETECTORS = [
     "detect-content",
     "detect-threshold",

tests/test_detectors.py

@@ -224,12 +224,3 @@ def test_detectors_with_stats(test_video_file):
         scene_manager.detect_scenes(video=video, end_time=end_time)
         scene_list = scene_manager.get_scene_list()
         assert len(scene_list) == initial_scene_len
-
-
-# TODO(v0.8): Remove this test during the removal of `scenedetect.scene_detector`.
-def test_deprecated_detector_module_emits_warning_on_import():
-    SCENE_DETECTOR_WARNING = (
-        "The `scene_detector` submodule is deprecated, import from the base package instead."
-    )
-    with pytest.warns(DeprecationWarning, match=SCENE_DETECTOR_WARNING):
-        from scenedetect.scene_detector import SceneDetector as _

tests/test_output.py

@@ -191,12 +191,3 @@ def test_save_images_zero_width_scene(test_video_file, tmp_path: Path):
             total_images += 1
 
     assert total_images == len([path for path in tmp_path.glob(image_name_glob)])
-
-
-# TODO(v0.8): Remove this test during the removal of `scenedetect.video_splitter`.
-def test_deprecated_output_modules_emits_warning_on_import():
-    VIDEO_SPLITTER_WARNING = (
-        "The `video_splitter` submodule is deprecated, import from the base package instead."
-    )
-    with pytest.warns(DeprecationWarning, match=VIDEO_SPLITTER_WARNING):
-        from scenedetect.video_splitter import split_video_ffmpeg as _

tests/test_stats_manager.py

@@ -27,8 +27,6 @@
 """
 
 import csv
-import os
-import random
 from pathlib import Path
 
 import pytest

tests/test_timecode.py

@@ -339,12 +339,3 @@ def test_timecode_frame_num_for_vfr():
     tc = FrameTimecode(timecode=Timecode(pts=1001, time_base=Fraction(1, 24000)), fps=fps)
     # Should not raise or warn - just return the approximate frame number.
     assert tc.frame_num == 1
-
-
-# TODO(v0.8): Remove this test during the removal of `scenedetect.scene_detector`.
-def test_deprecated_timecode_module_emits_warning_on_import():
-    FRAME_TIMECODE_WARNING = (
-        "The `frame_timecode` submodule is deprecated, import from the base package instead."
-    )
-    with pytest.warns(DeprecationWarning, match=FRAME_TIMECODE_WARNING):
-        from scenedetect.frame_timecode import FrameTimecode as _