[build] Fix portable suffixes

Author: Breakthrough

RELEASE-PLAN.md

@@ -45,8 +45,8 @@ Optional: version referenced below as `X.Y[.Z]` - replace with the real version
 - [ ] Tag `vX.Y[.Z]-release` on that commit and push. Wait for all tests/builds to pass.
 - [ ] Approve code signing request on SignPath, download `scenedetect-signed.zip`
 - [ ] Finalize Windows artifacts locally (CI can't do this - signing happens after the AppVeyor build, so the signed-exe swap and hashing must run locally):
-  - Create `dist/signed/` and copy in both `scenedetect-signed.zip` (from SignPath) and `PySceneDetect-X.Y.Z.zip` (from the AppVeyor `PySceneDetect-win64` artifact).
-  - Run `python scripts/finalize_windows_dist.py`. This swaps the signed `scenedetect.exe` into the portable `.zip`, repacks it with 7-Zip, copies out the signed `.msi`, and writes `PySceneDetect-X.Y.Z.manifest.json` + `SHA256SUMS`.
+  - Create `dist/signed/` and copy in both `scenedetect-signed.zip` (from SignPath) and `PySceneDetect-X.Y.Z-win64.zip` (from the AppVeyor `PySceneDetect-win64` artifact).
+  - Run `python scripts/finalize_windows_dist.py`. This swaps the signed `scenedetect.exe` into the portable `.zip`, repacks it with 7-Zip, copies out the signed `.msi`, and writes `PySceneDetect-X.Y.Z-win64.manifest.json` + `SHA256SUMS`.
 - [ ] Draft release on Github using the tagged commit: include full changelog & release notes, signed portable .ZIP, signed .MSI installer, Python .whl/.tar.gz packages, and checksum manifests (`PySceneDetect-X.Y.Z.manifest.json` + `SHA256SUMS`)
 - [ ] Verify all artifacts uploaded to Github release are valid and named correctly
 - [ ] Smoke-test all release artifacts

appveyor.yml

@@ -133,8 +133,8 @@ test_script:
   - scenedetect.exe -i ../../tests/resources/testvideo.mp4 -b pyav detect-content time -e 2s
 
 artifacts:
-  # Portable ZIP (named PySceneDetect-X.Y.Z.zip by stage_windows_dist.py)
-  - path: dist/PySceneDetect-*.zip
+  # Portable ZIP (named PySceneDetect-X.Y.Z-win64.zip by stage_windows_dist.py)
+  - path: dist/PySceneDetect-*-win64.zip
     name: PySceneDetect-win64
   # MSI Installer + .EXE Bundle for Signing
   - path: dist/scenedetect-signed.zip

scripts/finalize_windows_dist.py

@@ -20,14 +20,14 @@
 has been downloaded.
 
 Expected inputs (in --staging-dir, default `dist/signed/`):
-    scenedetect-signed.zip              - SignPath bundle (signed .exe + .msi)
-    PySceneDetect-X.Y.Z.zip             - portable .zip from AppVeyor
+    scenedetect-signed.zip                    - SignPath bundle (signed .exe + .msi)
+    PySceneDetect-X.Y.Z-win64.zip             - portable .zip from AppVeyor
 
 Outputs (written to the same directory):
-    PySceneDetect-X.Y.Z.zip    - repacked with the signed .exe
-    PySceneDetect-X.Y.Z-win64.msi       - signed MSI extracted from the bundle
-    PySceneDetect-X.Y.Z.manifest.json   - structured per-file SHA256 manifest
-    SHA256SUMS                          - flat sha256sum -c compatible output
+    PySceneDetect-X.Y.Z-win64.zip             - repacked with the signed .exe
+    PySceneDetect-X.Y.Z-win64.msi             - signed MSI extracted from the bundle
+    PySceneDetect-X.Y.Z-win64.manifest.json   - structured per-file SHA256 manifest
+    SHA256SUMS                                - flat sha256sum -c compatible output
 """
 
 import argparse
@@ -229,7 +229,7 @@ def write_manifests(staging: Path, portable_zip: Path, msi: Path) -> None:
         },
     }
 
-    manifest_path = staging / f"PySceneDetect-{VERSION}.manifest.json"
+    manifest_path = staging / f"PySceneDetect-{VERSION}-win64.manifest.json"
     sums_path = staging / "SHA256SUMS"
     manifest_path.write_text(json.dumps(manifest, indent=2) + "\n", encoding="utf-8")
     sums_path.write_text(
@@ -246,7 +246,7 @@ def main() -> None:
         "--staging-dir",
         type=Path,
         default=REPO_DIR / "dist" / "signed",
-        help="Directory holding scenedetect-signed.zip and PySceneDetect-*.zip.",
+        help="Directory holding scenedetect-signed.zip and PySceneDetect-*-win64.zip.",
     )
     args = parser.parse_args()
 
@@ -255,7 +255,7 @@ def main() -> None:
         sys.exit(f"{staging} not found")
 
     signed_bundle = staging / "scenedetect-signed.zip"
-    portable_zip = staging / f"PySceneDetect-{VERSION}.zip"
+    portable_zip = staging / f"PySceneDetect-{VERSION}-win64.zip"
     if not signed_bundle.is_file():
         sys.exit(f"{signed_bundle} not found")
     if not portable_zip.is_file():

scripts/stage_windows_dist.py

@@ -153,8 +153,8 @@ def stage_thirdparty_licenses() -> None:
 
 
 def make_portable_zip(version: str) -> None:
-    zip_path = DIST_DIR / f"PySceneDetect-{version}.zip"
-    manifest_path = DIST_DIR / f"PySceneDetect-{version}.manifest.txt"
+    zip_path = DIST_DIR / f"PySceneDetect-{version}-win64.zip"
+    manifest_path = DIST_DIR / f"PySceneDetect-{version}-win64.manifest.txt"
     if zip_path.exists():
         zip_path.unlink()
     print(f"Creating {zip_path.relative_to(REPO_DIR)}...")