Conversation
Removes the execOTA() call from the daily firmware check loop. The onAvailable callback already publishes the update-available MQTT state; the install should only start when Home Assistant sends a command via the update/set topic or a forced OTA is requested via the HTTP API. Closes #682 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execOTA()call from the dailyFIRMWARE_CHECK_SECONDSloop; theonAvailablecallback already publishes the update-available MQTT stateelse→else if(!updateAvailable)so the "no update" MQTT publish doesn't overwrite the state thatonAvailablejust set when an update is foundupdate/settopic (existing MQTT handler at line 4380) or a forced OTA is requested via the HTTP API (otaFirmware_checkPending()at line 3810)Test plan
update/stateshows update available, device does not start flashingdo-updatetoFireFly/{UUID}/update/set→ device downloads and installs firmwareupdate/availability=online,latest_version= current versionCloses #682
🤖 Generated with Claude Code