Skip to content

fix: daily OTA check publishes MQTT state instead of auto-installing #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrentIO merged 1 commit into from
Jun 21, 2026
+2 −4
Merged

fix: daily OTA check publishes MQTT state instead of auto-installing #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Controller/Controller.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,9 +879,7 @@ void loop() {
_otaCheckErrorCode = 0;
bool updateAvailable = otaFirmware.checkForUpdate();

if(updateAvailable){
otaFirmware.execOTA(); /* onAvailable already published MQTT update-available state */
} else if(_otaCheckFailed){
if(_otaCheckFailed){
eventLog.createEvent("OTA check failed");
/* onError already published "offline" to availability topic; do not overwrite with "online" */
if(deviceIdentity.enabled && mqttClient.connected()){
Expand Down Expand Up @@ -924,7 +922,7 @@ void loop() {
bufferedNotify.flush();
mqttClient.endPublish();
}
} else {
} else if(!updateAvailable){
/* Service reachable, no update — publish online + current version */
if(deviceIdentity.enabled && mqttClient.connected()){
char availability_topic[MQTT_TOPIC_UPDATE_AVAILABILITY_LENGTH+1];
Expand Down
Loading