Conversation
Calling execOTA() directly inside the MQTT message handler blocked while downloading firmware, causing MQTT to disconnect. Mirrors the forced-update pattern: set _otaNonForcedPendingRequest in the callback and execute from the main loop after MQTT processing is complete. Closes #686 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Both forced and HA-triggered updates now share _otaPendingRequest. otaFirmware_checkPending() dispatches on _otaPendingDoc.size() == 0 to distinguish the two paths rather than needing a second flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otaFirmware.execOTA()was being called directly inside the MQTT message handler, blocking for the entire firmware download while still inside the MQTT receive callback. CallingmqttClient.loop()re-entrantly from within a callback it fired caused MQTT to disconnect._otaNonForcedPendingRequest = truein the MQTT callback and executesexecOTA()from the main loop after MQTT processing is complete.Closes #686
Test plan
🤖 Generated with Claude Code