Conversation
…ress mqttClient.publish() silently drops payloads over 192 bytes (256-byte MQTT buffer minus 64 bytes of header/topic overhead). The onProgress JSON with release_url, title, and all state fields exceeds that limit, so the broker never receives percentage or title updates. Closes #693 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mqttClient.publish(topic, buffer)in theonProgressOTA callback with thebeginPublish / BufferingPrint / endPublishpattern used everywhere else for large MQTT payloadspublish()overload silently drops payloads over 192 bytes; theonProgressJSON withrelease_urlandtitleexceeds that limit, causing the broker to retain the initial{in_progress:true, update_percentage:0}message unchanged for the duration of the downloadchar buffer[384]stack allocation from the callbackTest plan
release_urlin the body and confirmupdate_percentageandtitleadvance in HA during downloadupdate/set ON) and confirm the same behavior is unaffectedonCompletestill publishes{in_progress:false}retained after the update finishesCloses #693
🤖 Generated with Claude Code