Skip to content

sp_Blitz: include affected foreign key count in “Foreign Keys Not Trusted” details #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrentOzar merged 2 commits into from
Apr 15, 2026
Merged

sp_Blitz: include affected foreign key count in “Foreign Keys Not Trusted” details #3912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d3db4
Initial plan
Copilot Apr 15, 2026
9fad54c
sp_Blitz: include foreign key count in untrusted FK warning details
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sp_Blitz.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7403,16 +7403,17 @@ IF NOT EXISTS ( SELECT 1
Finding,
URL,
Details)
SELECT DISTINCT 48,
SELECT 48,
N''?'',
150,
''Performance'',
''Foreign Keys Not Trusted'',
''https://www.brentozar.com/go/trust'',
(''The ['' + DB_NAME() + ''] database has foreign keys that were probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'')
(''The ['' + DB_NAME() + ''] database has '' + CAST(COUNT(*) AS NVARCHAR(20)) + '' foreign keys that were probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'')

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated Details string will produce grammatically incorrect output when exactly 1 foreign key is affected ("1 foreign keys"). Consider adding singular/plural handling so the message reads correctly for both 1 and >1.

Suggested change
(''The ['' + DB_NAME() + ''] database has '' + CAST(COUNT(*) AS NVARCHAR(20)) + '' foreign keys that were probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'')
(''The ['' + DB_NAME() + ''] database has '' + CAST(COUNT(*) AS NVARCHAR(20)) + CASE WHEN COUNT(*) = 1 THEN '' foreign key that was probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'' ELSE '' foreign keys that were probably disabled, data was changed, and then the key was enabled again. Simply enabling the key is not enough for the optimizer to use this key - we have to alter the table using the WITH CHECK CHECK CONSTRAINT parameter.'' END)

Copilot uses AI. Check for mistakes.
from [?].sys.foreign_keys i INNER JOIN [?].sys.objects o ON i.parent_object_id = o.object_id INNER JOIN [?].sys.schemas s ON o.schema_id = s.schema_id

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this check aggregates to a single row, the joins to sys.objects and sys.schemas are no longer used for filtering or output. Consider removing the joins and counting directly from sys.foreign_keys to reduce query work and keep the check simpler.

Suggested change
from [?].sys.foreign_keys i INNER JOIN [?].sys.objects o ON i.parent_object_id = o.object_id INNER JOIN [?].sys.schemas s ON o.schema_id = s.schema_id
from [?].sys.foreign_keys i

Copilot uses AI. Check for mistakes.
WHERE i.is_not_trusted = 1 AND i.is_not_for_replication = 0 AND i.is_disabled = 0 AND ''?''
NOT IN (''gcloud_cloudsqladmin'', ''master'', ''model'', ''msdb'', ''rdsadmin'', ''ReportServer'', ''ReportServerTempDB'')
HAVING COUNT(*) > 0
OPTION (RECOMPILE);';
END;

Expand Down