fix: set maximum spacer length to 10 and fix TypeScript definition

The TypeScript definition was not correct and is now working as
expected.

The spacer argument was not limited to 10 as it should be to be
spec compliant.

Author: BridgeAR

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v2.0.1
+
+- Fixed maximum spacer length (10)
+- Fixed TypeScript definition
+
 ## v2.0.0
 
 - __[BREAKING]__ Convert BigInt to number by default instead of ignoring these values

index.d.ts

@@ -1,14 +1,16 @@
-declare function stringify(value: any, replacer?: (key: string, value: any) => any, space?: string | number): string;
-declare function stringify(value: any, replacer?: (number | string)[] | null, space?: string | number): string;
+export function stringify(value: any, replacer?: (key: string, value: any) => any, space?: string | number): string;
+export function stringify(value: any, replacer?: (number | string)[] | null, space?: string | number): string;
 
 export interface StringifyOptions {
   bigint?: boolean,
   circularValue?: string | null,
   deterministic?: boolean,
 }
 
-declare function configure(StringifyOptions): stringify;
+export namespace stringify {
+  export function configure(options: StringifyOptions): typeof stringify;
+}
 
-stringify.configure = configure;
+export function configure(options: StringifyOptions): typeof stringify;
 
 export default stringify;

index.js

@@ -1,9 +1,15 @@
 'use strict'
 
 const stringify = main()
+
 stringify.configure = main
+stringify.stringify = stringify
+
 stringify.default = stringify
 
+exports.stringify = stringify
+exports.configure = main
+
 module.exports = stringify
 
 // eslint-disable-next-line
@@ -122,30 +128,20 @@ function getCircularValueOption (options) {
   return circularValue === undefined ? '"[Circular]"' : circularValue
 }
 
-function getBigIntOption (options) {
-  if (options && Object.prototype.hasOwnProperty.call(options, 'bigint')) {
-    var bigint = options.bigint
-    if (typeof bigint !== 'boolean') {
-      throw new TypeError('The "bigint" argument must be of type boolean')
-    }
-  }
-  return bigint === undefined ? true : bigint
-}
-
-function getDeterministicOption (options) {
-  if (options && Object.prototype.hasOwnProperty.call(options, 'deterministic')) {
-    var deterministic = options.deterministic
-    if (typeof deterministic !== 'boolean') {
-      throw new TypeError('The "deterministic" argument must be of type boolean')
+function getBooleanOption (options, key) {
+  if (options && Object.prototype.hasOwnProperty.call(options, key)) {
+    var value = options[key]
+    if (typeof value !== 'boolean') {
+      throw new TypeError(`The "${key}" argument must be of type boolean`)
     }
   }
-  return deterministic === undefined ? true : deterministic
+  return value === undefined ? true : value
 }
 
 function main (options) {
   const circularValue = getCircularValueOption(options)
-  const bigint = getBigIntOption(options)
-  const deterministic = getDeterministicOption(options)
+  const bigint = getBooleanOption(options, 'bigint')
+  const deterministic = getBooleanOption(options, 'deterministic')
 
   // Full version: supports all options
   function stringifyFullFn (key, parent, stack, replacer, spacer, indentation) {
@@ -480,9 +476,9 @@ function main (options) {
     if (arguments.length > 1) {
       let spacer = ''
       if (typeof space === 'number') {
-        spacer = ' '.repeat(space)
+        spacer = ' '.repeat(Math.min(space, 10))
       } else if (typeof space === 'string') {
-        spacer = space
+        spacer = space.slice(0, 10)
       }
       if (replacer != null) {
         if (typeof replacer === 'function') {

package.json

@@ -25,11 +25,12 @@
     "test": "standard && tap test.js",
     "benchmark": "node benchmark.js",
     "compare": "node compare.js",
-    "lint": "standard --fix"
+    "lint": "standard --fix",
+    "tsc": "tsc"
   },
   "author": "Ruben Bridgewater",
   "license": "MIT",
-  "typings": "index",
+  "typings": "index.d.ts",
   "devDependencies": {
     "@types/json-stable-stringify": "^1.0.32",
     "benchmark": "^2.1.4",
@@ -42,7 +43,8 @@
     "json-stringify-deterministic": "^1.0.1",
     "json-stringify-safe": "^5.0.1",
     "standard": "^15.0.0",
-    "tap": "^15.0.9"
+    "tap": "^15.0.9",
+    "typescript": "^4.4.3"
   },
   "repository": {
     "type": "git",

test.js

@@ -609,13 +609,32 @@ test('check small typed arrays with extra properties', function (assert) {
 })
 
 test('trigger sorting fast path for objects with lots of properties', function (assert) {
+  const keys = []
   const obj = {}
   for (let i = 0; i < 1e4; i++) {
     obj[`a${i}`] = i
+    keys.push(`a${i}`)
   }
+
   const start = Date.now()
+
   stringify(obj)
   assert.ok(Date.now() - start < 100)
+  const now = Date.now()
+  const actualTime = now - start
+  keys.sort()
+  const expectedTime = Date.now() - now
+  assert.ok(Math.abs(actualTime - expectedTime) < 25)
+  assert.end()
+})
+
+test('maximum spacer length', function (assert) {
+  const input = { a: 0 }
+  const expected = `{\n${' '.repeat(10)}"a": 0\n}`
+  assert.equal(stringify(input, 11), expected)
+  assert.equal(stringify(input, 1e5), expected)
+  assert.equal(stringify(input, ' '.repeat(11)), expected)
+  assert.equal(stringify(input, ' '.repeat(1e3)), expected)
   assert.end()
 })