Skip to content

fix: do not throw on a negative number space #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: do not throw on a negative number space #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ function configure (options) {
if (arguments.length > 1) {
let spacer = ''
if (typeof space === 'number') {
spacer = ' '.repeat(Math.min(space, 10))
spacer = ' '.repeat(Math.max(0, Math.min(space, 10)))
} else if (typeof space === 'string') {
spacer = space.slice(0, 10)
}
Expand Down
9 changes: 9 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,15 @@ test('maximum spacer length', function (assert) {
assert.end()
})

test('negative spacer length', function (assert) {
const input = { a: 0 }
// A negative number means no indentation, same as JSON.stringify (not a throw).
assert.equal(stringify(input, null, -1), JSON.stringify(input, null, -1))
assert.equal(stringify(input, null, -1e5), JSON.stringify(input, null, -1e5))
assert.equal(stringify(input, null, -Infinity), JSON.stringify(input, null, -Infinity))
assert.end()
})

test('indent properly; regression test for issue #16', function (assert) {
const o = {
collections: {},
Expand Down