Skip to content

Commit e8d5ce7

Browse files
holytshirtclaude
andcommitted
fix: remove duplicate AddGlobalInboxAttributesAsync call in async pipeline builder
The async BuildAsyncPipeline method had a duplicate call to AddGlobalInboxAttributesAsync outside the cache-miss block, causing static cache pollution between tests. Tests without inbox configuration would pick up cached inbox attributes from earlier tests, then fail with ArgumentOutOfRangeException when the handler factory couldn't create UseInboxHandlerAsync. The sync BuildPipeline method correctly only calls AddGlobalInboxAttributes once inside the cache-miss block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 832962e commit e8d5ce7

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

src/Paramore.Brighter/PipelineBuilder.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,6 @@ private IHandleRequestsAsync<TRequest> BuildAsyncPipeline(RequestHandlerAsync<TR
256256

257257
}
258258

259-
260-
AddGlobalInboxAttributesAsync(ref preAttributes, implicitHandler);
261-
262259
var firstInPipeline = PushOntoAsyncPipeline(preAttributes, implicitHandler, requestContext, instanceScope, continueOnCapturedContext);
263260

264261
if (!s_postAttributesMemento.TryGetValue(implicitHandler.Name.ToString(), out IOrderedEnumerable<RequestHandlerAttribute>? postAttributes))

0 commit comments

Comments
 (0)