Merge pull request #2 from BroWar-Collective/hotfix/history-null-loop

Hotfix/history-stack-overflow

Author: Madoww

Assets/Package/Runtime/Console/ConsoleManager.cs

@@ -27,19 +27,23 @@ public class ConsoleManager : MonoBehaviour, IConsoleManager
         private ConsoleHistory inputHistory;
 
         private bool isInitialized;
+        private bool isInitializing;
 
         private void EnsureInitialized()
         {
-            if (isInitialized)
+            if (isInitialized || isInitializing)
             {
                 return;
             }
 
-            isInitialized = true;
-            InitializeCache();
+            isInitializing = true;
+
             ValidateSettings();
             InitializeHistory();
             InitializeCommands();
+
+            isInitialized = true;
+            isInitializing = false;
         }
 
         private void ValidateSettings()
@@ -63,6 +67,8 @@ private void InitializeHistory()
 
         private void InitializeCommands()
         {
+            InitializeCache();
+
             var commandsRepository = settings.CommandsRepository;
             var commandsList = commandsRepository.commands;
             for (int i = 0; i < commandsList.Count; i++)
@@ -145,7 +151,7 @@ private bool TryMatchMethod(string commandNameLowerCased, string[] arguments, Ha
             return false;
         }
 
-        private void RegistorMethodFromCommand(ConsoleCommand command, MethodInfo method)
+        private void RegisterMethodFromCommand(ConsoleCommand command, MethodInfo method)
         {
             var commandName = method.Name.ToLower();
             if (namesToMethods.TryGetValue(commandName, out var methodsGroup))
@@ -177,7 +183,7 @@ public void AppendCommand(ConsoleCommand command)
             var commandInfo = commandType.GetTypeInfo();
             foreach (var method in commandInfo.DeclaredMethods.Where(method => method.IsPublic))
             {
-                RegistorMethodFromCommand(command, method);
+                RegisterMethodFromCommand(command, method);
             }
         }