Skip to content

Commit be66bb0

Browse files
crisdosaygoclaude
andcommitted
Make Windows signing non-blocking
Add continue-on-error for signing step to allow unsigned releases when certificate/password issues occur. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 173b86e commit be66bb0

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,8 @@ jobs:
324324
run: cargo build --release --features production -p fips-pad-ui
325325

326326
- name: Sign binary
327-
if: env.WIN_CODESIGN_PFX_B64 != ''
327+
if: ${{ secrets.WIN_CODESIGN_PFX_B64 != '' }}
328+
continue-on-error: true
328329
env:
329330
WIN_CODESIGN_PFX_B64: ${{ secrets.WIN_CODESIGN_PFX_B64 }}
330331
WIN_PASS: ${{ secrets.WIN_CODESIGN_PFX_PASS }}
@@ -343,7 +344,11 @@ jobs:
343344
/tr "http://timestamp.digicert.com" /td SHA256 `
344345
/d "FIPSPad" `
345346
"target\release\fips-pad.exe"
346-
Write-Host "Signed successfully"
347+
if ($LASTEXITCODE -ne 0) {
348+
Write-Host "Signing failed (exit code $LASTEXITCODE), continuing without signature"
349+
} else {
350+
Write-Host "Signed successfully"
351+
}
347352
} else {
348353
Write-Host "signtool not found, skipping"
349354
}

0 commit comments

Comments
 (0)