Skip to content

Commit f05e848

Browse files
committed
Refactor dependency resolution methods in CodeTide and PythonParser for improved clarity and consistency
1 parent 14d30d5 commit f05e848

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

codetide/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ def _get_language_from_extension(filepath: Path) -> Optional[str]:
356356
def _resolve_files_dependencies(self):
357357
for _, parser in self._instantiated_parsers.items():
358358
parser.resolve_inter_files_dependencies(self.codebase)
359-
parser.resolve_intra_file_dependencies(self.codebase.root)
359+
parser.resolve_intra_file_dependencies(self.codebase)
360360

361361
def _get_changed_files(self) -> Tuple[List[Path], bool]:
362362
"""

codetide/core/models.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ def as_list_str(self)->List[List[str]]:
366366

367367
for entry in self.classes.values():
368368
raw_elements_by_file[entry.file_path].append(f"\n{entry.raw}")
369+
369370
for entry in self.classes_headers.values():
370371
raw_elements_by_file[entry.file_path].append(f"\n{self.trim(entry.raw)}")
371372

@@ -713,6 +714,8 @@ def _render_class_contents(self, class_def: 'ClassDefinition', prefix: str,
713714
lines.append(f"{prefix}{current_prefix}{name}")
714715

715716
def get(self, unique_id :Union[str, List[str]], degree :int=1, as_string :bool=False, as_list_str :bool=False, slim :Optional[bool]=False, preloaded_files :Optional[Dict[str, str]]=None)->Union[CodeContextStructure, str, List[str]]:
717+
# TODO slim mode is still not perfect as in codecontext it should still heck for individual methods / dependencies which it does not do so far
718+
# need to refine it further
716719
if not self._cached_elements:
717720
logger.debug("Building cached elements for the first time")
718721
self._build_cached_elements()

codetide/parsers/python_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,8 +468,8 @@ def count_occurences_in_code(code: str, substring: str) -> int:
468468
matches = re.findall(pattern, code)
469469
return len(matches)
470470

471-
def resolve_intra_file_dependencies(self, codeFiles: List[CodeFileModel]) -> None:
472-
for codeFile in codeFiles:
471+
def resolve_intra_file_dependencies(self, codeBase: CodeBase) -> None:
472+
for codeFile in codeBase.root:
473473
if not codeFile.file_path.endswith(self.extension):
474474
continue
475475

0 commit comments

Comments
 (0)