fix: remove componentStack attachment override (#22)

Author: bobbyg603

package-lock.json

@@ -36,7 +36,7 @@
   "author": "zmrl",
   "license": "MIT",
   "dependencies": {
-    "bugsplat": "^9.1.0"
+    "bugsplat": "^9.1.1"
   },
   "devDependencies": {
     "@bugsplat/js-api-client": "^2.0.0",

package.json

@@ -152,7 +152,7 @@ describe('<ErrorBoundary />', () => {
         await waitFor(() => expect(mockPost).toHaveBeenCalledTimes(1));
       });
 
-      it('should attach componentStack as a text/plain Blob by default', async () => {
+      it('should attach componentStack as a Blob', async () => {
         render(
           <ErrorBoundary scope={scope} fallback={BasicFallback}>
             <BlowUp />
@@ -169,24 +169,6 @@ describe('<ErrorBoundary />', () => {
         expect(attachment.data.type).toBe('text/plain');
       });
 
-      it('honors scope.getCreateComponentStackAttachment() when provided', async () => {
-        const customAttachment = { filename: 'componentStack.txt', data: 'CUSTOM' };
-        const customBuilder = jest.fn(() => customAttachment);
-        const scopeWithBuilder = new Scope(bugSplat, customBuilder);
-
-        render(
-          <ErrorBoundary scope={scopeWithBuilder} fallback={BasicFallback}>
-            <BlowUp />
-          </ErrorBoundary>
-        );
-
-        await waitFor(() => expect(mockPost).toHaveBeenCalledTimes(1));
-
-        expect(customBuilder).toHaveBeenCalledWith(expect.stringContaining('BlowUp'));
-        const [, options] = mockPost.mock.calls[0];
-        expect(options.attachments).toEqual([customAttachment]);
-      });
-
       it('should call beforePost', async () => {
         render(
           <ErrorBoundary

spec/ErrorBoundary.spec.tsx

@@ -1,6 +1,5 @@
 import {
   type BugSplat,
-  type BugSplatAttachment,
   type BugSplatResponse,
 } from 'bugsplat';
 import {
@@ -11,8 +10,7 @@ import {
   type ReactElement,
   type ReactNode,
 } from 'react';
-import { appScope } from './appScope';
-import type { Scope } from './scope';
+import { getBugSplat } from './appScope';
 
 /**
  * Shallowly compare two arrays to determine if they are different.
@@ -139,7 +137,7 @@ interface InternalErrorBoundaryProps {
    * to pass their own scope that will inject the client for use by
    * ErrorBoundary.
    */
-  scope: Pick<Scope, 'getClient' | 'getCreateComponentStackAttachment'>;
+  scope: { getClient(): BugSplat | null };
 }
 
 export type ErrorBoundaryProps = JSX.LibraryManagedAttributes<
@@ -199,7 +197,7 @@ export class ErrorBoundary extends Component<
     onResetKeysChange: noop,
     onUnmount: noop,
     disablePost: false,
-    scope: appScope,
+    scope: { getClient: getBugSplat },
   };
 
   state = INITIAL_STATE;
@@ -247,7 +245,7 @@ export class ErrorBoundary extends Component<
 
     return client.post(error, {
       attachments: componentStack
-        ? [scope.getCreateComponentStackAttachment()(componentStack)]
+        ? [{ filename: 'componentStack.txt', data: new Blob([componentStack], { type: 'text/plain' }) }]
         : [],
     });
   }

src/ErrorBoundary.tsx

@@ -7,7 +7,6 @@ export type {
 
 export * from './appScope';
 export * from './ErrorBoundary';
-export * from './scope';
 export * from './useErrorHandler';
 export * from './useFeedback';
 export * from './withErrorBoundary';

src/index.ts

@@ -1,30 +1,10 @@
-import type { BugSplat, BugSplatAttachment } from 'bugsplat';
+import type { BugSplat } from 'bugsplat';
 
 /**
- * Builds the componentStack attachment for ErrorBoundary posts.
- */
-export type CreateComponentStackAttachment = (
-  componentStack: string
-) => BugSplatAttachment;
-
-/**
- * Default builder — wraps the stack in a `text/plain` `Blob`.
- */
-export const defaultCreateComponentStackAttachment: CreateComponentStackAttachment = (
-  componentStack
-) => ({
-  filename: 'componentStack.txt',
-  data: new Blob([componentStack], { type: 'text/plain' }),
-});
-
-/**
- * Encapsulate BugSplat client instance and scope-level overrides.
+ * Encapsulate BugSplat client instance
  */
 export class Scope {
-  constructor(
-    private client: BugSplat | null = null,
-    private createComponentStackAttachment: CreateComponentStackAttachment = defaultCreateComponentStackAttachment
-  ) {}
+  constructor(private client: BugSplat | null = null) {}
 
   /**
    * @returns BugSplat client instance or null if unset
@@ -36,15 +16,4 @@ export class Scope {
   setClient(client: BugSplat) {
     this.client = client;
   }
-
-  /**
-   * @returns the current componentStack attachment builder
-   */
-  getCreateComponentStackAttachment() {
-    return this.createComponentStackAttachment;
-  }
-
-  setCreateComponentStackAttachment(fn: CreateComponentStackAttachment) {
-    this.createComponentStackAttachment = fn;
-  }
 }