Skip to content

fix: ignore missing dbgId for unreal syms#191

Merged
bobbyg603 merged 3 commits into
mainfrom
unreal-sym-fix
Apr 9, 2026
Merged

fix: ignore missing dbgId for unreal syms#191
bobbyg603 merged 3 commits into
mainfrom
unreal-sym-fix

Conversation

@bobbyg603
Copy link
Copy Markdown
Member

@bobbyg603 bobbyg603 commented Apr 9, 2026

Description

Unreal has their own sym file format... It's a funky binary encoded file with no UUID. Here's what it looks like decoded:

[0] 0x05bc9000  _start  <out of bounds>:?
[1] 0x05bc902b  deregister_tm_clones  <out of bounds>:?
[2] 0x05bc904d  register_tm_clones  <out of bounds>:?
[3] 0x05bc9086  __do_global_dtors_aux  <out of bounds>:?
[4] 0x05bc90f5  frame_dummy  <out of bounds>:?
[5] 0x05bc9100  BuildSettings::IsLicenseeVersion()  D:/HordeSandbox/Full/Sync/Engine/Source/./Runtime/BuildSettings/Private/BuildSettings.cpp:9
[6] 0x05bc9103  ?????????????  <out of bounds>:?
[7] 0x05bc9110  BuildSettings::GetCurrentChangelist()  D:/HordeSandbox/Full/Sync/Engine/Source/./Runtime/BuildSettings/Private/BuildSettings.cpp:34
[8] 0x05bc9113  ?????????????  <out of bounds>:?
[9] 0x05bc9120  BuildSettings::GetCompatibleChangelist()  D:/HordeSandbox/Full/Sync/Engine/Source/./Runtime/BuildSettings/Private/BuildSettings.cpp:39

We load these files by matching application name/version. Fix by allowing this to fall through to our legacy symbol server path.

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

Copilot AI review requested due to automatic review settings April 9, 2026 17:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the symbol upload worker to avoid skipping certain symbol-like artifacts that lack a dbgId (notably Unreal-generated symbols), so they can be uploaded via the legacy (app/version-based) symbol upload path instead of the UUID-based path.

Changes:

  • Adds logic in UploadWorker.uploadSingle to route additional files to the legacy upload path when dbgId is missing.
  • Minor formatting cleanup in src/sym.ts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/worker.ts Adds new conditional handling intended to treat Unreal symbols without dbgId as legacy uploads rather than skipping.
src/sym.ts Removes an extra blank line in a comment block (no functional behavior change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/worker.ts
Comment thread src/worker.ts Outdated
Comment thread src/worker.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bobbyg603 bobbyg603 merged commit a32b938 into main Apr 9, 2026
7 checks passed
@bobbyg603 bobbyg603 deleted the unreal-sym-fix branch April 9, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants