Feature/customer rest api by abiodunaremu · Pull Request #22 · BuildForSDG/Team-064-Backend

abiodunaremu · 2020-06-01T08:08:31Z

Description

Created the following REST endpoints

Customer signup
Search Customer by criteria
Search Customer by Id
Reset password
Customer sign in
Customer logout
Token verification

Fixes #8 #9 #21

How Has This Been Tested?

Postman-Rest Client

Checklist:

[x ] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[ x] I have added necessary inline code documentation
I have added tests that prove my fix is effective and that this feature works
New and existing unit tests pass locally with my changes

abiodunaremu · 2020-06-01T20:50:07Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 379
           

Complexity increasing per file
==============================
- customer_service/lib/FileManager/FileType/FileTypeHandler.php  6
- customer_service/lib/ErrorReporter/ObjectError.php  1
- customer_service/lib/ResponseBuilder/JsonResponseBuilder.php  8
- customer_service/lib/EmailManager/PHPMailerEmailAPI.php  4
- customer_service/lib/FileManager/FileCreator/FileCreatorHandler.php  6
- customer_service/lib/DatabaseManager/DatabaseManager.php  2
- customer_service/lib/FileManager/FileManager.php  1
- customer_service/lib/FileManager/FileFormatter/FileFormatterFactory.php  1
- customer_service/lib/FileManager/FileFormatter/Image/JPEGImageFileFormatter.php  3
- customer_service/lib/ResponseBuilder/JsonHandler.php  1
- customer_service/lib/EmailManager/ResetPasswordEmailContent.php  3
- customer_service/lib/FileManager/File/PersistFileHandler.php  6
- customer_service/lib/FileManager/FileFormatter/FileFormatterPool.php  4
- customer_service/lib/FileUploadManager/FileUploadManager.php  1
- customer_service/lib/EmailManager/EmailManager.php  2
- customer_service/lib/EmailManager/SMTPEmailConnection.php  1
- customer_service/lib/FileUploadManager/MultipleFileUploader.php  5
- customer_service/lib/FileManager/FileGroup/FileGroupHandler.php  6
- customer_service/lib/FileUploadManager/SingleFileUploader.php  3
- customer_service/src/Services/CustomerService.php  2
- customer_service/lib/EmailManager/SignupEmailContent.php  3
- customer_service/lib/FileManager/FileType/FileType.php  1
- customer_service/lib/ResponseBuilder/JsonClientResponseArray.php  3
- customer_service/src/Repositories/CustomerSessionRepository.php  6
- customer_service/src/Controllers/CustomerController.php  6
- customer_service/lib/EmailManager/SMTPEmailConnectionFactory.php  1
- customer_service/src/Models/CustomerModel.php  3
- customer_service/src/Services/CustomerSessionService.php  3
- customer_service/lib/ErrorReporter/PersistenceError.php  1
- customer_service/src/Controllers/CustomerSessionController.php  4
- customer_service/lib/ErrorReporter/ErrorReporter.php  2
- customer_service/lib/FileManager/File/LogicFile.php  2
- customer_service/lib/FileManager/FileGroup/FileGroup.php  1
- customer_service/lib/ErrorReporter/EmptyError.php  1
- customer_service/lib/FileManager/File/PersistFile.php  1
- customer_service/src/Repositories/CustomerRepository.php  8
- customer_service/lib/ResponseBuilder/JsonClientResponseData.php  3
- customer_service/src/Models/CustomerSessionModel.php  1
- customer_service/src/Controllers/ApplicationController.php  1
- customer_service/lib/FileManager/FileCreator/FileCreator.php  1
- customer_service/lib/ErrorReporter/ErrorNodeFactory.php  1
- customer_service/lib/ErrorReporter/Errors.php  2
         

Clones added
============
- customer_service/lib/EmailManager/ResetPasswordEmailContent.php  1
- customer_service/lib/FileUploadManager/MultipleFileUploader.php  1
- customer_service/lib/FileUploadManager/SingleFileUploader.php  1
- customer_service/lib/EmailManager/SignupEmailContent.php  1

See the complete overview on Codacy

abiodunaremu · 2020-06-01T20:50:07Z

+
+        if ($this->customer === null) {
+            $responseData->addValue("href", "app/customers");
+            echo $responseBuilder->setName("resetcustomerpassword")


Issue found: All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$responseBuilder'.

abiodunaremu · 2020-06-01T20:50:08Z

+        SET vhTimeOut = NULL;
+        SET vhTimeLastCheck = NOW();
+        SET chCheckState = chStartState;
+        SET chEndState = NULL;


Issue found: syntax error at or near "NULL"

abiodunaremu · 2020-06-01T20:50:09Z

+            $errorMessages = $errorMessages.$jsonHandler->quoteString("errors")
+            ." : [{".
+            $jsonHandler->quoteString("head")." : ";
+            $headError = ErrorReporter::getResponseMessageType() === 0 ?


Issue found: Avoid using static access to class '\Lib\ErrorReporter\ErrorReporter' in method 'build'.

abiodunaremu · 2020-06-01T20:50:10Z

+CALL prnInsCountry('BAHAMAS');
+CALL prnInsCountry('BAHRAIN');
+CALL prnInsCountry('BANGLADESH');  
+CALL prnInsCountry('BARBADOS');


Issue found: syntax error at or near "CALL"

abiodunaremu · 2020-06-01T20:50:11Z

+        SET chStatus=@Status;
+    END IF;
+
+    IF thDescription='' OR thDescription IS NULL


Issue found: syntax error at or near "IF"

abiodunaremu · 2020-06-01T20:50:12Z

+header("Access-Control-Allow-Methods: GET,HEAD,OPTIONS,POST,PUT");
+header("access-control-allow-methods: GET,HEAD,OPTIONS,POST,PUT");
+header("Access-Control-Allow-Headers: Or_+_igin, X-Requested-With, Content-Type, Accept, Authorization,Access-Control-Allow-Origin,access-control-allow-headers");
+header("access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization,Access-Control-Allow-Origin,access-control-allow-headers,access-control-allow-methods");


Issue found: The use of function header() is discouraged

abiodunaremu · 2020-06-01T20:50:13Z

+if(in_array($_SERVER['REQUEST_METHOD'], array('POST', 'PUT', 'DELETE'))) {
+
+    //Make sure that the content type of the request has been set to application/json
+    $contentType = isset($_SERVER["CONTENT_TYPE"]) ? trim($_SERVER["CONTENT_TYPE"]) : '';


Issue found: $_SERVER data not unslashed before sanitization. Use wp_unslash() or similar

abiodunaremu · 2020-06-01T20:50:14Z

+	ELSE
+		SET @A='Nill';/**SELECT 'Specified Currency Name not be found';**/
+	END IF;
+    END$$


Issue found: syntax error at or near "END$$"

abiodunaremu · 2020-06-01T20:50:15Z

+                                "Class:FileHandler->persistFile; Empty status returned ",
+                                "Unable to register file.<br/>Please try again Later"
+                            );
+                            ErrorReporter::addNode($errorNode);


Issue found: Avoid using static access to class '\Lib\ErrorReporter\ErrorReporter' in method 'persistFile'.

abiodunaremu · 2020-06-01T20:50:16Z

+CALL prnInsCountry('AUSTRALIA');
+CALL prnInsCountry('AUSTRIA');
+CALL prnInsCountry('AZERBAIJAN');  
+CALL prnInsCountry('BAHAMAS');


Issue found: syntax error at or near "CALL"

abiodunaremu · 2020-06-01T20:50:17Z

+        SET vhName=@Name;
+    END IF;
+
+    IF chStatus='' OR chStatus IS NULL


Issue found: syntax error at or near "IF"

abiodunaremu · 2020-06-01T20:50:18Z

+dLastUpdate datetime not null,
+cStatus char(1) not null
+);
+alter table `broomy_db`.`FileType` auto_increment = 1;


Issue found: syntax error at or near "`"

abiodunaremu · 2020-06-01T20:50:19Z

+CALL prnInsCountry('CENTRAL AFRICAN');
+CALL prnInsCountry('REPUBLIC');
+CALL prnInsCountry('CHAD');
+CALL prnInsCountry('CHILE');


Issue found: syntax error at or near "CALL"

abiodunaremu · 2020-06-01T20:50:19Z

+        return $this->id;
+    }
+
+    public function setId($id)


Issue found: Avoid variables with short names like $id. Configured minimum length is 3.

abiodunaremu · 2020-06-01T20:50:20Z

+            if (DatabaseManager::mysql_query($query)) {
+                $result = DatabaseManager::mysql_query($querySelectHolder);
+                if ($result) {
+                    $num_results = DatabaseManager::mysql_num_rows($result);


Issue found: Avoid using static access to class '\Lib\Database\DatabaseManager' in method 'persistFile'.

abiodunaremu · 2020-06-01T20:50:21Z

+                "Customer Object already exist: will not create new user ",
+                "Internal error occured. Please try again later."
+            );
+            ErrorReporter::addNode($errorNode);


Issue found: Avoid using static access to class '\Lib\ErrorReporter\ErrorReporter' in method 'registerCustomer'.

abiodunaremu · 2020-06-01T20:50:22Z

+        return $this->id;
+    }
+
+    public function setId($id)


Issue found: Avoid variables with short names like $id. Configured minimum length is 3.

abiodunaremu · 2020-06-01T20:50:23Z

+    {
+        if ($this->nextNode) {
+            return $this->nextNode;
+        } else {


Issue found: The method getNextNode uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

abiodunaremu · 2020-06-01T20:50:24Z

@@ -0,0 +1,88 @@
+USE broomy_db;
+
+DROP TABLE IF EXISTS `broomy_db`.`FileType`;


Issue found: syntax error at or near "`"

abiodunaremu · 2020-06-01T20:50:25Z

+                $this->decoded['dateofbirth']
+            );
+        } elseif (strcasecmp($_SERVER['REQUEST_METHOD'], 'GET')
+            === 0 && sizeof($this->params) === $this->index_entity+2) {


Issue found: The use of function sizeof() is discouraged; use count() instead.

abiodunaremu · 2020-06-01T20:50:26Z

+    public function persistFile($sessionId, $fileGroupId, $fileType, $oldName, $fileDirPath, $extension, $size)
+    {
+        $error = "";
+        $response = "";


Issue found: Avoid unused local variables such as '$response'.

abiodunaremu · 2020-06-01T20:50:27Z

+USE broomy_db;
+
+DROP TABLE IF EXISTS `broomy_db`.`CustomerSession`;
+CREATE TABLE `broomy_db`.`CustomerSession`


Issue found: syntax error at or near "`"

abiodunaremu · 2020-06-01T20:50:27Z

+        $row="";
+        $response="";
+        $error="";
+        $result = DatabaseManager::mysql_query($query);


Issue found: Avoid using static access to class '\Lib\Database\DatabaseManager' in method 'getFileGroups'.

abiodunaremu · 2020-06-01T20:50:28Z

+		SET CountryCode=CONCAT('0',CAST(COUNTER AS CHAR(3)));
+		WHEN COUNTER>99 and COUNTER<=999 THEN
+		SET CountryCode=CAST(COUNTER AS CHAR(3));
+	END CASE;


Issue found: syntax error at or near "CASE"

abiodunaremu · 2020-06-01T20:50:29Z

+        } elseif (strcasecmp($_SERVER['REQUEST_METHOD'], 'GET')
+            === 0 && sizeof($this->params) === $this->index_entity+2) {
+            //retrieve customer information by id
+            $customerId = $this->params[sizeof($this->params)-1];


Issue found: The use of function sizeof() is discouraged; use count() instead.

abiodunaremu commented Jun 1, 2020

View reviewed changes

Merge pull request #23 from BuildForSDG/feature/appproperties

cf72b75

johnsonfash force-pushed the feature/customer-rest-api branch from 25b8cb9 to cf72b75 Compare July 1, 2026 08:43

		@@ -0,0 +1,88 @@
		USE broomy_db;

		DROP TABLE IF EXISTS `broomy_db`.`FileType`;

Uh oh!

Conversation

abiodunaremu commented Jun 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Uh oh!

abiodunaremu commented Jun 1, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

abiodunaremu commented Jun 1, 2020 •

edited

Loading