fix: deduplicate crawled URLs, fix -m flag collision, add elapsed time + userAgent support#415
Open
VaishnavGunjari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Bug fixes
-mCLI flag: Both--matchand--maxPagesToCrawlwere registered with the same-mshorthand, causing silent option shadowing. Fixed by changing--maxPagesToCrawlto-n.RESOURCE_EXCLUSTIONS→RESOURCE_EXCLUSIONS(affected all 3 usages).Improvements
seenUrlsSet to skip already-visited URLs during a crawl, preventing duplicate entries in the output and wasted requests.✅ Crawl complete: N page(s) crawled in Xs) is printed when the crawl finishes.userAgentconfig option: Users can now set auserAgentstring inconfig.tsto override the default Playwright User-Agent on every request.No breaking changes
All changes are backward-compatible. New config fields are optional.