Fix flaky test for dynamic mapping#227
Open
rayshrey wants to merge 2 commits into
Open
Conversation
Signed-off-by: rayshrey <rayshrey@amazon.com>
Bukhtawar
reviewed
May 19, 2026
Comment on lines
+187
to
+193
| assertBusy(() -> { | ||
| GetMappingsResponse extraMappingsResponse = client().admin().indices().prepareGetMappings(INDEX_NAME).get(); | ||
| Map<String, Object> extraMappingSource = extraMappingsResponse.mappings().get(INDEX_NAME).sourceAsMap(); | ||
| @SuppressWarnings("unchecked") | ||
| Map<String, Object> finalProperties = (Map<String, Object>) extraMappingSource.get("properties"); | ||
| assertTrue("Mapping should contain dynamic field 'dynamic_extra'", finalProperties.containsKey("dynamic_extra")); | ||
| }); |
Author
There was a problem hiding this comment.
The field name are different but yes can create a helper function which takes a list of field name to assert on. Let me add that
Author
There was a problem hiding this comment.
Done. Updated in the latest revision.
Signed-off-by: rayshrey <rayshrey@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.