Skip to content

Commit 1f17571

Browse files
committed
fix: add helpers to avoid long lines
1 parent 95a39ce commit 1f17571

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

app/services/players/roster_management_service.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ def calculate_recent_performance(player, limit: 50)
326326
avg_cs_per_min: recent_stats.average(:cs_per_min)&.to_f&.round(1) || 0.0,
327327
avg_vision_score: recent_stats.average(:vision_score)&.to_f&.round(1) || 0.0,
328328
avg_damage_share: damage_shares.any? ? (damage_shares.sum / damage_shares.size).round(1) : 0.0,
329-
avg_kill_participation: kill_participations.any? ? (kill_participations.sum / kill_participations.size).round(1) : 0.0,
329+
avg_kill_participation: avg_value_from(kill_participations),
330330
last_game_date: last_game_date_for(recent_stats)
331331
}
332332
end
@@ -368,6 +368,11 @@ def calculate_win_rate(stats)
368368
(wins.to_f / stats.count * 100).round(1)
369369
end
370370

371+
# Helper to average a compact array of values, returns 0.0 if empty
372+
def avg_value_from(values)
373+
values.any? ? (values.sum / values.size).round(1) : 0.0
374+
end
375+
371376
# Helper to extract last game date without deep safe navigation chain
372377
def last_game_date_for(stats)
373378
first_stat = stats.first

0 commit comments

Comments
 (0)