Merge PS005 into master

feat: implement vod review module

Author: Bulletdev

app/controllers/api/v1/vod_reviews_controller.rb

@@ -2,17 +2,17 @@ class Api::V1::VodReviewsController < Api::V1::BaseController
   before_action :set_vod_review, only: [:show, :update, :destroy]
 
   def index
-    vod_reviews = organization_scoped(VodReview).includes(:match, :reviewed_by)
+    authorize VodReview
+    vod_reviews = organization_scoped(VodReview).includes(:match, :reviewer)
 
     # Apply filters
     vod_reviews = vod_reviews.where(status: params[:status]) if params[:status].present?
-    vod_reviews = vod_reviews.where(vod_platform: params[:platform]) if params[:platform].present?
 
     # Match filter
     vod_reviews = vod_reviews.where(match_id: params[:match_id]) if params[:match_id].present?
 
     # Reviewed by filter
-    vod_reviews = vod_reviews.where(reviewed_by_id: params[:reviewed_by_id]) if params[:reviewed_by_id].present?
+    vod_reviews = vod_reviews.where(reviewer_id: params[:reviewer_id]) if params[:reviewer_id].present?
 
     # Search by title
     if params[:search].present?
@@ -35,6 +35,7 @@ def index
   end
 
   def show
+    authorize @vod_review
     vod_review_data = VodReviewSerializer.render_as_hash(@vod_review)
     timestamps = VodTimestampSerializer.render_as_hash(
       @vod_review.vod_timestamps.includes(:target_player, :created_by).order(:timestamp_seconds)
@@ -47,9 +48,10 @@ def show
   end
 
   def create
+    authorize VodReview
     vod_review = organization_scoped(VodReview).new(vod_review_params)
     vod_review.organization = current_organization
-    vod_review.reviewed_by = current_user
+    vod_review.reviewer = current_user
 
     if vod_review.save
       log_user_action(
@@ -73,6 +75,7 @@ def create
   end
 
   def update
+    authorize @vod_review
     old_values = @vod_review.attributes.dup
 
     if @vod_review.update(vod_review_params)
@@ -98,6 +101,7 @@ def update
   end
 
   def destroy
+    authorize @vod_review
     if @vod_review.destroy
       log_user_action(
         action: 'delete',
@@ -124,8 +128,10 @@ def set_vod_review
 
   def vod_review_params
     params.require(:vod_review).permit(
-      :title, :vod_url, :vod_platform, :game_start_timestamp,
-      :status, :notes, :match_id
+      :title, :description, :review_type, :review_date,
+      :video_url, :thumbnail_url, :duration,
+      :status, :is_public, :match_id,
+      tags: [], shared_with_players: []
     )
   end
 end

app/controllers/api/v1/vod_timestamps_controller.rb

@@ -3,6 +3,7 @@ class Api::V1::VodTimestampsController < Api::V1::BaseController
   before_action :set_vod_timestamp, only: [:update, :destroy]
 
   def index
+    authorize @vod_review, :show?
     timestamps = @vod_review.vod_timestamps
                  .includes(:target_player, :created_by)
                  .order(:timestamp_seconds)
@@ -18,6 +19,7 @@ def index
   end
 
   def create
+    authorize @vod_review, :update?
     timestamp = @vod_review.vod_timestamps.new(vod_timestamp_params)
     timestamp.created_by = current_user
 
@@ -43,6 +45,7 @@ def create
   end
 
   def update
+    authorize @timestamp.vod_review, :update?
     old_values = @timestamp.attributes.dup
 
     if @timestamp.update(vod_timestamp_params)
@@ -68,6 +71,7 @@ def update
   end
 
   def destroy
+    authorize @timestamp.vod_review, :update?
     if @timestamp.destroy
       log_user_action(
         action: 'delete',
@@ -101,7 +105,7 @@ def set_vod_timestamp
   def vod_timestamp_params
     params.require(:vod_timestamp).permit(
       :timestamp_seconds, :category, :importance,
-      :title, :description, :target_player_id
+      :title, :description, :target_type, :target_player_id
     )
   end
 end

app/serializers/vod_review_serializer.rb

@@ -1,14 +1,17 @@
 class VodReviewSerializer < Blueprinter::Base
   identifier :id
 
-  fields :title, :vod_url, :vod_platform, :game_start_timestamp,
-         :status, :notes, :created_at, :updated_at
+  fields :title, :description, :review_type, :review_date,
+         :video_url, :thumbnail_url, :duration,
+         :is_public, :share_link, :shared_with_players,
+         :status, :tags, :metadata,
+         :created_at, :updated_at
 
   field :timestamps_count do |vod_review, options|
     options[:include_timestamps_count] ? vod_review.vod_timestamps.count : nil
   end
 
   association :organization, blueprint: OrganizationSerializer
   association :match, blueprint: MatchSerializer
-  association :reviewed_by, blueprint: UserSerializer
+  association :reviewer, blueprint: UserSerializer
 end

spec/factories/vod_reviews.rb

@@ -0,0 +1,37 @@
+FactoryBot.define do
+  factory :vod_review do
+    association :organization
+    association :reviewer, factory: :user
+    association :match, factory: :match
+
+    title { Faker::Lorem.sentence(word_count: 3) }
+    description { Faker::Lorem.paragraph }
+    review_type { %w[team individual opponent].sample }
+    review_date { Faker::Time.between(from: 30.days.ago, to: Time.current) }
+    video_url { "https://www.youtube.com/watch?v=#{Faker::Alphanumeric.alpha(number: 11)}" }
+    thumbnail_url { Faker::Internet.url }
+    duration { rand(1800..3600) }
+    status { 'draft' }
+    is_public { false }
+    tags { %w[scrim review analysis].sample(2) }
+
+    trait :published do
+      status { 'published' }
+    end
+
+    trait :archived do
+      status { 'archived' }
+    end
+
+    trait :public do
+      is_public { true }
+      share_link { SecureRandom.urlsafe_base64(16) }
+    end
+
+    trait :with_timestamps do
+      after(:create) do |vod_review|
+        create_list(:vod_timestamp, 3, vod_review: vod_review)
+      end
+    end
+  end
+end

spec/factories/vod_timestamps.rb

@@ -0,0 +1,31 @@
+FactoryBot.define do
+  factory :vod_timestamp do
+    association :vod_review
+    association :target_player, factory: :player
+    association :created_by, factory: :user
+
+    timestamp_seconds { rand(60..3600) }
+    title { Faker::Lorem.sentence(word_count: 3) }
+    description { Faker::Lorem.paragraph }
+    category { %w[mistake good_play team_fight objective laning].sample }
+    importance { %w[low normal high critical].sample }
+    target_type { %w[player team opponent].sample }
+
+    trait :mistake do
+      category { 'mistake' }
+      importance { %w[high critical].sample }
+    end
+
+    trait :good_play do
+      category { 'good_play' }
+    end
+
+    trait :critical do
+      importance { 'critical' }
+    end
+
+    trait :important do
+      importance { 'high' }
+    end
+  end
+end