fix: adjust draft plans serializer

Author: Bulletdev

app/controllers/api/v1/strategy/draft_plans_controller.rb

@@ -17,7 +17,7 @@ def index
           result = paginate(plans)
 
           render_success({
-                           draft_plans: Strategy::Serializers::DraftPlanSerializer.render_as_hash(result[:data]),
+                           draft_plans: ::Strategy::Serializers::DraftPlanSerializer.render_as_hash(result[:data]),
                            total: result[:pagination][:total_count],
                            page: result[:pagination][:current_page],
                            per_page: result[:pagination][:per_page],
@@ -28,7 +28,7 @@ def index
         # GET /api/v1/strategy/draft_plans/:id
         def show
           render_success({
-                           draft_plan: Strategy::Serializers::DraftPlanSerializer.render_as_hash(@draft_plan)
+                           draft_plan: ::Strategy::Serializers::DraftPlanSerializer.render_as_hash(@draft_plan)
                          })
         end
 
@@ -48,7 +48,7 @@ def create
             )
 
             render_created({
-                             draft_plan: Strategy::Serializers::DraftPlanSerializer.render_as_hash(plan)
+                             draft_plan: ::Strategy::Serializers::DraftPlanSerializer.render_as_hash(plan)
                            }, message: 'Draft plan created successfully')
           else
             render_error(
@@ -75,7 +75,7 @@ def update
             )
 
             render_updated({
-                             draft_plan: Strategy::Serializers::DraftPlanSerializer.render_as_hash(@draft_plan)
+                             draft_plan: ::Strategy::Serializers::DraftPlanSerializer.render_as_hash(@draft_plan)
                            })
           else
             render_error(

app/models/draft_plan.rb

@@ -111,6 +111,37 @@ def activate!
     update!(is_active: true)
   end
 
+  # Check if we have priority picks for all roles
+  def blind_pick_ready?
+    Constants::Player::ROLES.all? { |role| priority_picks&.key?(role) }
+  end
+
+  # Calculate what percentage of possible scenarios are covered
+  def scenario_coverage
+    return 0 if total_scenarios.zero?
+
+    # Simplified coverage calculation
+    # In a real scenario, this would analyze ban combinations
+    [((total_scenarios / 10.0) * 100).round(2), 100].min
+  end
+
+  # Check how many opponent comfort picks are banned
+  def comfort_picks_coverage
+    comfort = opponent_comfort_picks
+    return 100 if comfort.empty?
+
+    banned = (our_bans & comfort).size
+    ((banned.to_f / comfort.size) * 100).round(2)
+  end
+
+  # Suggest additional bans based on opponent comfort picks
+  def suggest_bans
+    comfort = opponent_comfort_picks
+    already_banned = our_bans || []
+
+    (comfort - already_banned).first(5)
+  end
+
   private
 
   def validate_bans_structure
@@ -165,37 +196,6 @@ def normalize_champion_names
     self.priority_picks = priority_picks.transform_values(&:strip)
   end
 
-  # Calculate what percentage of possible scenarios are covered
-  def scenario_coverage
-    return 0 if total_scenarios.zero?
-
-    # Simplified coverage calculation
-    # In a real scenario, this would analyze ban combinations
-    [((total_scenarios / 10.0) * 100).round(2), 100].min
-  end
-
-  # Check how many opponent comfort picks are banned
-  def comfort_picks_coverage
-    comfort = opponent_comfort_picks
-    return 100 if comfort.empty?
-
-    banned = (our_bans & comfort).size
-    ((banned.to_f / comfort.size) * 100).round(2)
-  end
-
-  # Suggest additional bans based on opponent comfort picks
-  def suggest_bans
-    comfort = opponent_comfort_picks
-    already_banned = our_bans || []
-
-    (comfort - already_banned).first(5)
-  end
-
-  # Check if we have priority picks for all roles
-  def blind_pick_ready?
-    Constants::Player::ROLES.all? { |role| priority_picks&.key?(role) }
-  end
-
   def log_audit_trail
     AuditLog.create!(
       organization: organization,