Skip to content

Commit 7357639

Browse files
committed
fix: solve semgrep issues to avoid warnings
1 parent 75d00b1 commit 7357639

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

app/modules/meta_intelligence/controllers/builds_controller.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,9 @@ def apply_filters(scope)
123123
end
124124

125125
def build_create_params
126-
# nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
127126
# :role is the LoL champion role (adc/jungle/mid/etc.), not a user authorization role.
128127
# SavedBuild has no admin/banned/account_id fields — mass assignment risk does not apply.
129-
params.require(:build).permit(
128+
params.require(:build).permit( # nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
130129
:champion, :role, :patch_version, :title, :notes, :is_public,
131130
:primary_rune_tree, :secondary_rune_tree,
132131
:summoner_spell_1, :summoner_spell_2, :trinket,

app/views/user_mailer/password_reset.html.erb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
<p>Click the button below to reset your password:</p>
88

99
<p style="text-align: center;">
10-
<%# nosemgrep: ruby.rails.security.audit.xss.templates.var-in-href.var-in-href
11-
@reset_url is validated in UserMailer#password_reset to be http/https only (URI::HTTP check) %>
12-
<a href="<%= @reset_url %>" class="button">Reset Password</a>
10+
<%# @reset_url is validated in UserMailer#password_reset to be http/https only (URI::HTTP check) %>
11+
<a href="<%= @reset_url %>" class="button">Reset Password</a><%# nosemgrep: ruby.rails.security.audit.xss.templates.var-in-href.var-in-href %>
1312
</p>
1413

1514
<p>Or copy and paste this link into your browser:</p>

0 commit comments

Comments
 (0)