feat: implement hire from scouting

Author: Bulletdev

app/modules/players/services/roster_management_service.rb

@@ -80,9 +80,12 @@ def self.hire_from_scouting(scouting_target:, organization:, contract_start:, co
         previous_organization_id: nil
       )
 
-      # Update watchlist status to signed
+      # Remove from org's watchlist — player is now on the roster
       watchlist = scouting_target.scouting_watchlists.find_by(organization: organization)
-      watchlist&.update!(status: 'signed')
+      watchlist&.destroy
+
+      # Clean up the global target if no other org is watching it
+      scouting_target.destroy if scouting_target.scouting_watchlists.none?
 
       # Log the action
       log_roster_addition(player, scouting_target, current_user)

app/modules/scouting/controllers/players_controller.rb

@@ -5,7 +5,8 @@ module Controllers
     # Scouting Players Controller
     # Manages GLOBAL scouting targets and org-specific watchlists
     class PlayersController < Api::V1::BaseController
-      before_action :set_scouting_target, only: %i[show update destroy sync]
+      before_action :set_scouting_target, only: %i[show update destroy sync import_to_roster]
+      before_action :require_management!, only: %i[import_to_roster]
 
       # GET /api/v1/scouting/players
       # Returns global scouting targets with optional watchlist filtering
@@ -104,6 +105,32 @@ def destroy
         render_deleted(message: 'Removed from watchlist')
       end
 
+      # POST /api/v1/scouting/players/:id/import_to_roster
+      # Hires the scouting target directly to the roster and removes them from scouting
+      def import_to_roster
+        result = RosterManagementService.hire_from_scouting(
+          scouting_target: @target,
+          organization: current_organization,
+          contract_start: params[:contract_start].present? ? Date.parse(params[:contract_start]) : nil,
+          contract_end: params[:contract_end].present? ? Date.parse(params[:contract_end]) : nil,
+          salary: params[:salary]&.to_d,
+          jersey_number: params[:jersey_number]&.to_i,
+          current_user: current_user
+        )
+
+        if result[:success]
+          render_created(
+            { player: PlayerSerializer.render_as_hash(result[:player]) },
+            message: result[:message]
+          )
+        else
+          render_error(message: result[:error], code: result[:code], status: :unprocessable_entity)
+        end
+      rescue ArgumentError
+        render_error(message: 'Invalid date format. Use YYYY-MM-DD', code: 'INVALID_DATE_FORMAT',
+                     status: :unprocessable_entity)
+      end
+
       def sync
         unless @target.riot_puuid.present?
           return render_error(
@@ -123,6 +150,16 @@ def sync
 
       private
 
+      def require_management!
+        return if %w[admin owner].include?(current_user.role)
+
+        render_error(
+          message: 'Only owners and admins can import players to the roster',
+          code: 'FORBIDDEN',
+          status: :forbidden
+        )
+      end
+
       def create_watchlist_for(target)
         target.scouting_watchlists.create!(
           organization: current_organization,

config/routes.rb

@@ -201,6 +201,7 @@
         resources :players, controller: '/scouting/controllers/players' do
           member do
             post :sync
+            post :import_to_roster
           end
         end
         get 'regions', to: '/scouting/controllers/regions#index'