Skip to content

Commit ae6beba

Browse files
committed
fix: solve semgrep false positive
1 parent 3d35e6b commit ae6beba

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

app/modules/scouting/controllers/players_controller.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,9 @@ def set_scouting_target
286286
end
287287

288288
def scouting_target_params
289+
# nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
290+
# :role here is the player's in-game position (top/jungle/mid/adc/support),
291+
# not an authorization role. ScoutingTarget has no privilege implications.
289292
params.require(:scouting_target).permit(
290293
:summoner_name, :real_name, :role, :region, :nationality,
291294
:age, :status, :current_team,
@@ -306,6 +309,9 @@ def watchlist_params
306309
end
307310

308311
def target_params
312+
# nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
313+
# :role here is the player's in-game position (top/jungle/mid/adc/support),
314+
# not an authorization role. ScoutingTarget has no privilege implications.
309315
params.fetch(:target, {}).permit(
310316
:summoner_name, :real_name, :role, :region, :nationality,
311317
:age, :status, :current_team,

0 commit comments

Comments
 (0)