Skip to content

Commit be7ca78

Browse files
committed
fix: solve semgrep inline suppress
1 parent ae6beba commit be7ca78

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

app/modules/scouting/controllers/players_controller.rb

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,8 @@ def set_scouting_target
286286
end
287287

288288
def scouting_target_params
289-
# nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
290-
# :role here is the player's in-game position (top/jungle/mid/adc/support),
291-
# not an authorization role. ScoutingTarget has no privilege implications.
292-
params.require(:scouting_target).permit(
289+
# :role is the LoL in-game position (top/jungle/mid/adc/support), not an authorization role.
290+
params.require(:scouting_target).permit( # nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
293291
:summoner_name, :real_name, :role, :region, :nationality,
294292
:age, :status, :current_team,
295293
:current_tier, :current_rank, :current_lp,
@@ -309,10 +307,8 @@ def watchlist_params
309307
end
310308

311309
def target_params
312-
# nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
313-
# :role here is the player's in-game position (top/jungle/mid/adc/support),
314-
# not an authorization role. ScoutingTarget has no privilege implications.
315-
params.fetch(:target, {}).permit(
310+
# :role is the LoL in-game position (top/jungle/mid/adc/support), not an authorization role.
311+
params.fetch(:target, {}).permit( # nosemgrep: ruby.lang.security.model-attr-accessible.model-attr-accessible
316312
:summoner_name, :real_name, :role, :region, :nationality,
317313
:age, :status, :current_team,
318314
:current_tier, :current_rank, :current_lp,

0 commit comments

Comments
 (0)