fix: solve match fingerprint mismatch

Author: Bulletdev

app/modules/competitive/concerns/match_fingerprint.rb

@@ -6,35 +6,40 @@
 # produce different external_match_id values for the same physical game. This
 # module derives a source-agnostic fingerprint so duplicates are caught before
 # they are persisted.
-module MatchFingerprint
-  # Generates a stable fingerprint for a physical game based on attributes that
-  # are source-agnostic.
-  #
-  # @param org_id [String] organization UUID
-  # @param match_date [DateTime, nil]
-  # @param game_number [Integer, nil] game within the series (1-5)
-  # @param opponent_name [String, nil]
-  # @return [String, nil] SHA-256 hex string, or nil when inputs are insufficient
-  def generate_fingerprint(org_id, match_date, game_number, opponent_name)
-    return nil if match_date.nil? || opponent_name.nil? || opponent_name.strip.empty?
+module Competitive
+  module Concerns
+    # Shared fingerprinting logic for deduplicating competitive match imports.
+    module MatchFingerprint
+      # Generates a stable fingerprint for a physical game based on attributes that
+      # are source-agnostic.
+      #
+      # @param org_id [String] organization UUID
+      # @param match_date [DateTime, nil]
+      # @param game_number [Integer, nil] game within the series (1-5)
+      # @param opponent_name [String, nil]
+      # @return [String, nil] SHA-256 hex string, or nil when inputs are insufficient
+      def generate_fingerprint(org_id, match_date, game_number, opponent_name)
+        return nil if match_date.nil? || opponent_name.nil? || opponent_name.strip.empty?
 
-    day = match_date.to_date.to_s
-    normalized = opponent_name.strip.downcase
-    Digest::SHA256.hexdigest("#{org_id}|#{day}|#{game_number || 1}|#{normalized}")
-  end
+        day = match_date.to_date.to_s
+        normalized = opponent_name.strip.downcase
+        Digest::SHA256.hexdigest("#{org_id}|#{day}|#{game_number || 1}|#{normalized}")
+      end
 
-  # Returns true if a record with this fingerprint already exists for the org.
-  # Skips the check when the fingerprint cannot be computed (missing inputs).
-  #
-  # @param organization [Organization]
-  # @param match_date [DateTime, nil]
-  # @param game_number [Integer, nil]
-  # @param opponent_name [String, nil]
-  # @return [Boolean]
-  def duplicate_by_fingerprint?(organization, match_date, game_number, opponent_name)
-    fp = generate_fingerprint(organization.id, match_date, game_number, opponent_name)
-    return false if fp.nil?
+      # Returns true if a record with this fingerprint already exists for the org.
+      # Skips the check when the fingerprint cannot be computed (missing inputs).
+      #
+      # @param organization [Organization]
+      # @param match_date [DateTime, nil]
+      # @param game_number [Integer, nil]
+      # @param opponent_name [String, nil]
+      # @return [Boolean]
+      def duplicate_by_fingerprint?(organization, match_date, game_number, opponent_name)
+        fp = generate_fingerprint(organization.id, match_date, game_number, opponent_name)
+        return false if fp.nil?
 
-    organization.competitive_matches.where(game_fingerprint: fp).exists?
+        organization.competitive_matches.where(game_fingerprint: fp).exists?
+      end
+    end
   end
 end

app/modules/competitive/services/leaguepedia_recovery_service.rb

@@ -20,7 +20,7 @@
 #   # => { recovered: 1, already_present: 12, errors: 0, skipped_no_players: 0 }
 #
 class LeaguepediaRecoveryService
-  include MatchFingerprint
+  include Competitive::Concerns::MatchFingerprint
 
   CARGO_BASE_URL = 'https://lol.fandom.com/api.php'
   CACHE_TTL      = 30.minutes

app/modules/competitive/services/scraper_importer_service.rb

@@ -12,7 +12,7 @@
 #   # => { imported: 5, skipped_duplicate: 3, skipped_unenriched: 2, errors: 0 }
 #
 class ScraperImporterService
-  include MatchFingerprint
+  include Competitive::Concerns::MatchFingerprint
 
   # Leaguepedia role values mapped to our internal lowercase convention
   ROLE_MAP = {

config/application.rb

@@ -44,7 +44,7 @@ class Application < Rails::Application
     # Serializers, policies, channels, and services keep their original flat class names.
     # Adding their dirs as roots (same pattern as models) avoids renaming every
     # constant: PlayerSerializer, PlayerPolicy, RiotApiService, etc. stay as-is.
-    %w[serializers policies channels services concerns].each do |layer|
+    %w[serializers policies channels services].each do |layer|
       Dir[root.join("app/modules/*/#{layer}")].each do |path|
         config.autoload_paths << path
         config.eager_load_paths << path