feat: implement fetch_account_by_puuid method

Author: Bulletdev

app/modules/players/jobs/sync_player_from_riot_job.rb

@@ -30,6 +30,9 @@ def perform(player_id)
                             fetch_summoner_by_name(player.summoner_name, region, riot_api_key)
                           end
 
+          # Fetch account data to get current gameName#tagLine
+          account_data = fetch_account_by_puuid(player.riot_puuid, region, riot_api_key)
+
           # Use PUUID for league endpoint (workaround for Riot API bug where summoner_data['id'] is nil)
           # See: https://github.com/RiotGames/developer-relations/issues/1092
           ranked_data = fetch_ranked_stats_by_puuid(player.riot_puuid, region, riot_api_key)
@@ -43,6 +46,15 @@ def perform(player_id)
             last_sync_at: Time.current
           }
 
+          # Update summoner_name if it has changed
+          if account_data['gameName'].present? && account_data['tagLine'].present?
+            new_summoner_name = "#{account_data['gameName']}##{account_data['tagLine']}"
+            if player.summoner_name != new_summoner_name
+              Rails.logger.info("Player #{player.id} name changed: #{player.summoner_name} → #{new_summoner_name}")
+              update_data[:summoner_name] = new_summoner_name
+            end
+          end
+
           solo_queue = ranked_data.find { |q| q['queueType'] == 'RANKED_SOLO_5x5' }
           if solo_queue
             update_data.merge!({
@@ -76,6 +88,36 @@ def perform(player_id)
 
       private
 
+      def fetch_account_by_puuid(puuid, region, api_key)
+        require 'net/http'
+        require 'json'
+
+        # Determine regional endpoint
+        regional_endpoint = case region.downcase
+                            when 'br1', 'na1', 'lan', 'las1'
+                              'americas'
+                            when 'euw1', 'eune1', 'ru', 'tr1'
+                              'europe'
+                            when 'kr', 'jp1', 'oce1'
+                              'asia'
+                            else
+                              'americas'
+                            end
+
+        url = "https://#{regional_endpoint}.api.riotgames.com/riot/account/v1/accounts/by-puuid/#{puuid}"
+        uri = URI(url)
+        request = Net::HTTP::Get.new(uri)
+        request['X-Riot-Token'] = api_key
+
+        response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+          http.request(request)
+        end
+
+        raise "Riot API Error: #{response.code} - #{response.body}" unless response.is_a?(Net::HTTPSuccess)
+
+        JSON.parse(response.body)
+      end
+
       def fetch_summoner_by_name(summoner_name, region, api_key)
         require 'net/http'
         require 'json'

app/modules/players/services/riot_sync_service.rb

@@ -118,15 +118,18 @@ def sync_player(player, import_matches: true)
         return { success: false, error: 'Player missing PUUID' } if player.riot_puuid.blank?
 
         begin
-          # 1. Fetch current rank and profile
+          # 1. Fetch account info to get current gameName#tagLine
+          account_data = fetch_account_by_puuid(player.riot_puuid)
+
+          # 2. Fetch current rank and profile
           summoner_data = fetch_summoner_by_puuid(player.riot_puuid)
           # Use PUUID to fetch rank data (summoner_id is no longer returned by Riot API)
           rank_data = fetch_rank_data_by_puuid(player.riot_puuid)
 
-          # 2. Update player with fresh data
-          update_player_from_riot(player, summoner_data, rank_data)
+          # 3. Update player with fresh data (including summoner_name if changed)
+          update_player_from_riot(player, account_data, summoner_data, rank_data)
 
-          # 3. Optionally fetch recent matches
+          # 4. Optionally fetch recent matches
           matches_imported = 0
           matches_imported = import_player_matches(player, count: 20) if import_matches
 
@@ -146,6 +149,19 @@ def sync_player(player, import_matches: true)
         end
       end
 
+      # Fetch account info (gameName, tagLine) by PUUID
+      def fetch_account_by_puuid(puuid)
+        regional_endpoint = get_regional_endpoint(region)
+
+        # Use whitelisted host to prevent SSRF
+        uri = URI::HTTPS.build(
+          host: regional_api_host(regional_endpoint),
+          path: "/riot/account/v1/accounts/by-puuid/#{ERB::Util.url_encode(puuid)}"
+        )
+        response = make_request(uri.to_s)
+        JSON.parse(response.body)
+      end
+
       # Fetch summoner by PUUID
       def fetch_summoner_by_puuid(puuid)
         # Use whitelisted host to prevent SSRF
@@ -216,26 +232,26 @@ def import_player_matches(player, count: 20)
 
       # Search for a player by Riot ID (GameName#TagLine)
       def search_riot_id(game_name, tag_line)
-        Rails.logger.info("🎮 Searching for Riot ID: #{game_name}##{tag_line}")
-        Rails.logger.info("🌍 Region: #{region}")
+        Rails.logger.info("Searching for Riot ID: #{game_name}##{tag_line}")
+        Rails.logger.info("Region: #{region}")
 
         regional_endpoint = get_regional_endpoint(region)
-        Rails.logger.info("🗺️  Regional endpoint: #{regional_endpoint}")
+        Rails.logger.info("Regional endpoint: #{regional_endpoint}")
 
         # Use whitelisted host to prevent SSRF
         # Use ERB::Util.url_encode instead of CGI.escape to properly encode spaces as %20 (not +)
         encoded_game_name = ERB::Util.url_encode(game_name)
         encoded_tag_line = ERB::Util.url_encode(tag_line)
 
-        Rails.logger.info("📝 Encoded game_name: '#{game_name}' -> '#{encoded_game_name}'")
-        Rails.logger.info("📝 Encoded tag_line: '#{tag_line}' -> '#{encoded_tag_line}'")
+        Rails.logger.info("Encoded game_name: '#{game_name}' -> '#{encoded_game_name}'")
+        Rails.logger.info("Encoded tag_line: '#{tag_line}' -> '#{encoded_tag_line}'")
 
         uri = URI::HTTPS.build(
           host: regional_api_host(regional_endpoint),
           path: "/riot/account/v1/accounts/by-riot-id/#{encoded_game_name}/#{encoded_tag_line}"
         )
 
-        Rails.logger.info("🔗 Full URL: #{uri}")
+        Rails.logger.info("Full URL: #{uri}")
 
         response = make_request(uri.to_s)
         account_data = JSON.parse(response.body)
@@ -254,9 +270,9 @@ def search_riot_id(game_name, tag_line)
           rank_data: rank_data
         }
       rescue StandardError => e
-        Rails.logger.error("❌ Failed to search Riot ID #{game_name}##{tag_line}: #{e.message}")
-        Rails.logger.error("❌ Exception class: #{e.class.name}")
-        Rails.logger.error("❌ Backtrace: #{e.backtrace.first(5).join("\n")}")
+        Rails.logger.error("Failed to search Riot ID #{game_name}##{tag_line}: #{e.message}")
+        Rails.logger.error("Exception class: #{e.class.name}")
+        Rails.logger.error("Backtrace: #{e.backtrace.first(5).join("\n")}")
         nil
       end
 
@@ -302,7 +318,7 @@ def check_existing_player(puuid, summoner_name, riot_data)
       # Log security warning when attempting to import player from another org
       def log_security_warning(summoner_name, riot_data, existing_player)
         Rails.logger.warn(
-          "⚠️  SECURITY: Attempt to import player #{summoner_name} " \
+          "  SECURITY: Attempt to import player #{summoner_name} " \
           "(PUUID: #{riot_data[:puuid]}) that belongs to organization " \
           "#{existing_player.organization.name} by organization #{organization.name}"
         )
@@ -372,16 +388,16 @@ def make_request(url)
         request['X-Riot-Token'] = api_key
 
         # Debug logging
-        Rails.logger.info("🔍 Making Riot API request to: #{uri}")
-        Rails.logger.info("🔑 API Key present: #{api_key.present?} (length: #{api_key&.length || 0})")
+        Rails.logger.info(" Making Riot API request to: #{uri}")
+        Rails.logger.info(" API Key present: #{api_key.present?} (length: #{api_key&.length || 0})")
 
         response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
           http.request(request)
         end
 
         unless response.is_a?(Net::HTTPSuccess)
           error_message = "Riot API Error: #{response.code} - #{response.body}"
-          Rails.logger.error("❌ Riot API Error - URL: #{uri} - Status: #{response.code} - Body: #{response.body}")
+          Rails.logger.error("Riot API Error - URL: #{uri} - Status: #{response.code} - Body: #{response.body}")
 
           # Create custom exception with status code for better error handling
           error = RiotApiError.new(error_message)
@@ -390,13 +406,13 @@ def make_request(url)
           raise error
         end
 
-        Rails.logger.info("✅ Riot API request successful: #{response.code}")
+        Rails.logger.info(" Riot API request successful: #{response.code}")
         response
       end
 
       # Update player with Riot data
-      def update_player_from_riot(player, summoner_data, rank_data)
-        player.update!(
+      def update_player_from_riot(player, account_data, summoner_data, rank_data)
+        update_attrs = {
           summoner_level: summoner_data['summonerLevel'],
           profile_icon_id: summoner_data['profileIconId'],
           solo_queue_tier: rank_data['tier'],
@@ -406,7 +422,18 @@ def update_player_from_riot(player, summoner_data, rank_data)
           solo_queue_losses: rank_data['losses'],
           last_sync_at: Time.current,
           sync_status: 'success'
-        )
+        }
+
+        # Update summoner_name if it has changed
+        if account_data['gameName'].present? && account_data['tagLine'].present?
+          new_summoner_name = "#{account_data['gameName']}##{account_data['tagLine']}"
+          if player.summoner_name != new_summoner_name
+            Rails.logger.info(" Player #{player.id} name changed: #{player.summoner_name} → #{new_summoner_name}")
+            update_attrs[:summoner_name] = new_summoner_name
+          end
+        end
+
+        player.update!(update_attrs)
       end
 
       # Import a match from Riot data

app/modules/riot_integration/services/riot_api_service.rb

@@ -38,6 +38,14 @@ def get_summoner_by_name(summoner_name:, region:)
     parse_summoner_response(response)
   end
 
+  def get_account_by_puuid(puuid:, region:)
+    regional_route = regional_route_for_region(region)
+    url = "https://#{regional_route}.api.riotgames.com/riot/account/v1/accounts/by-puuid/#{puuid}"
+
+    response = make_request(url)
+    parse_account_response(response)
+  end
+
   def get_summoner_by_puuid(puuid:, region:)
     platform = platform_for_region(region)
     url = "https://#{platform}.api.riotgames.com/lol/summoner/v4/summoners/by-puuid/#{puuid}"
@@ -179,6 +187,15 @@ def normalize_region(region)
     platform_to_region[normalized] || normalized
   end
 
+  def parse_account_response(response)
+    data = JSON.parse(response.body)
+    {
+      puuid: data['puuid'],
+      game_name: data['gameName'],
+      tag_line: data['tagLine']
+    }
+  end
+
   def parse_summoner_response(response)
     data = JSON.parse(response.body)
     {

app/modules/scouting/jobs/sync_scouting_target_job.rb

@@ -26,6 +26,22 @@ def perform(scouting_target_id)
           )
         end
 
+        # Fetch account data to update summoner_name if changed
+        if target.riot_puuid.present?
+          account_data = riot_service.get_account_by_puuid(
+            puuid: target.riot_puuid,
+            region: target.region
+          )
+
+          if account_data[:game_name].present? && account_data[:tag_line].present?
+            new_summoner_name = "#{account_data[:game_name]}##{account_data[:tag_line]}"
+            if target.summoner_name != new_summoner_name
+              Rails.logger.info("Scouting target #{target.id} name changed: #{target.summoner_name} → #{new_summoner_name}")
+              target.update!(summoner_name: new_summoner_name)
+            end
+          end
+        end
+
         if target.riot_summoner_id.present?
           league_data = riot_service.get_league_entries(
             summoner_id: target.riot_summoner_id,

app/services/riot_api_service.rb

@@ -75,6 +75,14 @@ def get_summoner_by_name(summoner_name:, region:)
     parse_summoner_response(response)
   end
 
+  def get_account_by_puuid(puuid:, region:)
+    regional_route = regional_route_for_region(region)
+    url = "https://#{regional_route}.api.riotgames.com/riot/account/v1/accounts/by-puuid/#{puuid}"
+
+    response = make_request(url)
+    parse_account_response(response)
+  end
+
   def get_summoner_by_puuid(puuid:, region:)
     platform = platform_for_region(region)
     url = "https://#{platform}.api.riotgames.com/lol/summoner/v4/summoners/by-puuid/#{puuid}"
@@ -190,6 +198,15 @@ def regional_route_for_region(region)
     REGIONS.dig(clean_region, :region) || raise(RiotApiError, "Unknown region: #{region}")
   end
 
+  def parse_account_response(response)
+    data = JSON.parse(response.body)
+    {
+      puuid: data['puuid'],
+      game_name: data['gameName'],
+      tag_line: data['tagLine']
+    }
+  end
+
   def parse_summoner_response(response)
     data = JSON.parse(response.body)
     {