fix: solve canvas drag issues

Author: Bulletdev

app/modules/strategy/controllers/tactical_boards_controller.rb

@@ -139,10 +139,14 @@ def apply_sorting(boards)
       end
 
       def tactical_board_params
-        # Support both nested format (tactical_board: {title:...}) and flat format (name:..., board_state:...)
-        # The frontend may send data at the top level with different field names.
+        # Support both nested format (tactical_board: {map_state:...}) and flat format (name:..., board_state:...)
+        # Always prefer the nested tactical_board hash when present — even partial updates
+        # (e.g. map_state only, no title) must read from tb, not from top-level params.
+        # The previous check `tb[:title].present? || tb[:name].present?` fell back to
+        # top-level params whenever an update omitted the title field, causing update({})
+        # to be called silently and saving nothing despite returning 200 OK.
         tb = params[:tactical_board]
-        source = tb.present? && (tb[:title].present? || tb[:name].present?) ? tb : params
+        source = tb.present? ? tb : params
 
         permitted = {
           title: source[:title] || source[:name],

app/modules/strategy/models/tactical_board.rb

@@ -220,15 +220,13 @@ def validate_annotation_structure(annotation, index)
       return
     end
 
-    unless annotation['type'] && annotation['x'] && annotation['y']
-      errors.add(:annotations, "annotation at index #{index} must have type, x, and y")
-    end
-
-    return unless annotation['x'] && annotation['y']
-
-    return if (0..100).cover?(annotation['x'].to_f) && (0..100).cover?(annotation['y'].to_f)
+    # Only require 'type'. Canvas annotations are heterogeneous:
+    #   - circle / text: have x, y (relative or pixel coords)
+    #   - line / arrow / pen: use a 'points' array, no x/y
+    # Requiring x/y and enforcing a 0-100 range breaks all point-based annotations.
+    return if annotation['type'].present?
 
-    errors.add(:annotations, "annotation at index #{index} coordinates must be between 0 and 100")
+    errors.add(:annotations, "annotation at index #{index} must have a type")
   end
 
   def validate_coordinates!(x, y)