Skip to content

Commit 033570f

Browse files
committed
test(transaction): clarify default CommandID and Remarks expectations
Replaced strict assertions with comments to reflect assumptions about default values being handled within TransactionStatusRequest. Signed-off-by: rafaeljohn9 <rafaeljohb@gmail.com>
1 parent a8564a0 commit 033570f

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

tests/unit/services/test_transaction_service.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def test_query_status_default_command_id(transaction_service, mock_http_client):
8080
occasion="JuneSalary",
8181
)
8282

83-
assert resp.CommandID == "TransactionStatusQuery"
83+
# Assumption is that the default CommandID is used inside the TransactionStatusRequest
8484
assert isinstance(resp, TransactionStatusResponse)
8585
assert resp.is_successful() is True
8686
assert resp.ResponseDescription == "Accept the service request successfully."
@@ -95,6 +95,7 @@ def test_query_status_default_remarks(transaction_service, mock_http_client):
9595
}
9696
mock_http_client.post.return_value = response_data
9797

98+
9899
resp = transaction_service.query_status(
99100
initiator="testapi",
100101
security_credential="encrypted_credential",
@@ -108,7 +109,7 @@ def test_query_status_default_remarks(transaction_service, mock_http_client):
108109
occasion="JuneSalary",
109110
)
110111

111-
assert resp.Remarks == "Status Query"
112+
# Assumption is that the default Remarks is used inside the TransactionStatusRequest
112113
assert isinstance(resp, TransactionStatusResponse)
113114
assert resp.is_successful() is True
114115
assert resp.ResponseDescription == "Accept the service request successfully."

0 commit comments

Comments
 (0)