Merge pull request #43 from RafaelJohn9/fix/service

fix: added the missing fields in the facade services

Author: RafaelJohn9

mpesakit/services/express.py

@@ -28,7 +28,6 @@ def __init__(self, http_client: HttpClient, token_manager: TokenManager) -> None
     def push(
         self,
         business_short_code: int,
-        passkey: str,
         transaction_type: str,
         amount: float,
         party_a: str,
@@ -37,13 +36,15 @@ def push(
         callback_url: str,
         account_reference: str,
         transaction_desc: str,
+        passkey: str | None = None,
+        timestamp: str | None = None,
+        password: str | None = None,
         **kwargs,
     ) -> StkPushSimulateResponse:
         """Initiate an M-Pesa STK Push transaction.
 
         Args:
             business_short_code: M-Pesa business shortcode.
-            passkey: M-Pesa passkey.
             transaction_type: Transaction type (e.g., 'CustomerPayBillOnline').
             amount: Transaction amount.
             party_a: MSISDN sending the funds.
@@ -52,14 +53,16 @@ def push(
             callback_url: URL for receiving the callback.
             account_reference: Reference for the transaction.
             transaction_desc: Description of the transaction.
+            passkey: M-Pesa passkey.
+            timestamp: Timestamp for the transaction.
+            password: Password for the transaction.
             **kwargs: Additional fields for StkPushSimulateRequest.
 
         Returns:
             StkPushSimulateResponse: Response from M-Pesa API.
         """
         request = StkPushSimulateRequest(
             BusinessShortCode=business_short_code,
-            Passkey=passkey,
             TransactionType=transaction_type,
             Amount=amount,
             PartyA=party_a,
@@ -68,6 +71,9 @@ def push(
             CallBackURL=callback_url,
             AccountReference=account_reference,
             TransactionDesc=transaction_desc,
+            Passkey=passkey,
+            Timestamp=timestamp,
+            Password=password,
             **{
                 k: v
                 for k, v in kwargs.items()

mpesakit/services/tax.py

@@ -31,6 +31,7 @@ def remittance(
         remarks: str,
         account_reference: str,
         result_url: str,
+        queue_timeout_url: str,
         **kwargs,
     ) -> TaxRemittanceResponse:
         """Initiate a tax remittance transaction.
@@ -43,6 +44,7 @@ def remittance(
             remarks: Additional remarks.
             account_reference: Account reference for the transaction.
             result_url: URL for result notification.
+            queue_timeout_url: URL for timeout notification.
             **kwargs: Additional fields for TaxRemittanceRequest.
 
         Returns:
@@ -56,6 +58,7 @@ def remittance(
             Remarks=remarks,
             AccountReference=account_reference,
             ResultURL=result_url,
+            QueueTimeOutURL=queue_timeout_url,
             **{
                 k: v
                 for k, v in kwargs.items()

tests/unit/services/test_tax_service.py

@@ -49,7 +49,7 @@ def test_remittance_calls_tax_remittance(tax_service, mock_http_client):
         remarks="OK",
         account_reference="353353",
         result_url="https://mydomain.com/b2b/remittax/result/",
-        QueueTimeOutURL="https://mydomain.com/b2b/remittax/queue/",
+        queue_timeout_url="https://mydomain.com/b2b/remittax/queue/",
     )
     assert isinstance(resp, TaxRemittanceResponse)
     assert resp.is_successful() is True
@@ -74,7 +74,7 @@ def test_remittance_filters_kwargs(tax_service, mock_http_client):
         remarks="OK",
         account_reference="353353",
         result_url="https://mydomain.com/b2b/remittax/result/",
-        QueueTimeOutURL="https://mydomain.com/b2b/remittax/queue/",
+        queue_timeout_url="https://mydomain.com/b2b/remittax/queue/",
         unexpected_field="should be ignored",
     )
     assert isinstance(resp, TaxRemittanceResponse)