refactor(core): Initial setup for execution data management (n8n-io#24452)

Author: ivov

…__tests__/execution-data.service.test.ts …ons/__tests__/failed-run-factory.test.tspackages/cli/src/executions/__tests__/execution-data.service.test.ts renamed to packages/cli/src/executions/__tests__/failed-run-factory.test.ts packages/cli/src/executions/__tests__/execution-data.service.test.ts renamed to packages/cli/src/executions/__tests__/failed-run-factory.test.ts

@@ -2,10 +2,10 @@ import { mock } from 'jest-mock-extended';
 import { NodeOperationError } from 'n8n-workflow';
 import type { INode, WorkflowExecuteMode } from 'n8n-workflow';
 
-import { ExecutionDataService } from '../execution-data.service';
+import { FailedRunFactory } from '../failed-run-factory';
 
-describe('ExecutionDataService', () => {
-	const service = new ExecutionDataService();
+describe('FailedRunFactory', () => {
+	const service = new FailedRunFactory();
 
 	describe('generateFailedExecutionFromError', () => {
 		const mode: WorkflowExecuteMode = 'manual';

packages/cli/src/executions/execution-data/types.ts

@@ -0,0 +1,19 @@
+import type { IWorkflowBase } from 'n8n-workflow';
+
+type ExecutionRef = {
+	workflowId: string;
+	executionId: string;
+};
+
+type ExecutionDataPayload = {
+	data: string;
+	workflowData: IWorkflowBase;
+	workflowVersionId: string | null;
+};
+
+export interface ExecutionDataManager {
+	init?(): Promise<void>;
+	write(ref: ExecutionRef, payload: ExecutionDataPayload): Promise<void>;
+	read(ref: ExecutionRef): Promise<ExecutionDataPayload>;
+	delete(ref: ExecutionRef | ExecutionRef[]): Promise<void>;
+}

…src/executions/execution-data.service.ts …cli/src/executions/failed-run-factory.tspackages/cli/src/executions/execution-data.service.ts renamed to packages/cli/src/executions/failed-run-factory.ts packages/cli/src/executions/execution-data.service.ts renamed to packages/cli/src/executions/failed-run-factory.ts

@@ -8,7 +8,7 @@ import {
 } from 'n8n-workflow';
 
 @Service()
-export class ExecutionDataService {
+export class FailedRunFactory {
 	generateFailedExecutionFromError(
 		mode: WorkflowExecuteMode,
 		error: ExecutionError,

packages/cli/src/workflow-execute-additional-data.ts

@@ -37,7 +37,7 @@ import { CredentialsHelper } from '@/credentials-helper';
 import { EventService } from '@/events/event.service';
 import type { AiEventMap, AiEventPayload } from '@/events/maps/ai.event-map';
 import { getLifecycleHooksForSubExecutions } from '@/execution-lifecycle/execution-lifecycle-hooks';
-import { ExecutionDataService } from '@/executions/execution-data.service';
+import { FailedRunFactory } from '@/executions/failed-run-factory';
 import { isManualOrChatExecution } from '@/executions/execution.utils';
 import {
 	CredentialsPermissionChecker,
@@ -342,7 +342,7 @@ async function startExecution(
 		data = await execution;
 	} catch (error) {
 		const executionError = error as ExecutionError;
-		const fullRunData = Container.get(ExecutionDataService).generateFailedExecutionFromError(
+		const fullRunData = Container.get(FailedRunFactory).generateFailedExecutionFromError(
 			runData.executionMode,
 			executionError,
 			'node' in executionError ? executionError.node : undefined,

packages/cli/src/workflow-runner.ts

@@ -35,7 +35,7 @@ import {
 	getLifecycleHooksForScalingWorker,
 	getLifecycleHooksForScalingMain,
 } from '@/execution-lifecycle/execution-lifecycle-hooks';
-import { ExecutionDataService } from '@/executions/execution-data.service';
+import { FailedRunFactory } from '@/executions/failed-run-factory';
 import { CredentialsPermissionChecker } from '@/executions/pre-execution-checks';
 import { ManualExecutionService } from '@/manual-execution.service';
 import { NodeTypes } from '@/node-types';
@@ -60,7 +60,7 @@ export class WorkflowRunner {
 		private readonly credentialsPermissionChecker: CredentialsPermissionChecker,
 		private readonly instanceSettings: InstanceSettings,
 		private readonly manualExecutionService: ManualExecutionService,
-		private readonly executionDataService: ExecutionDataService,
+		private readonly failedRunFactory: FailedRunFactory,
 		private readonly eventService: EventService,
 		private readonly executionsConfig: ExecutionsConfig,
 	) {}
@@ -147,7 +147,7 @@ export class WorkflowRunner {
 			await this.credentialsPermissionChecker.check(workflowId, nodes);
 		} catch (error) {
 			// Create a failed execution with the data for the node, save it and abort execution
-			const runData = this.executionDataService.generateFailedExecutionFromError(
+			const runData = this.failedRunFactory.generateFailedExecutionFromError(
 				data.executionMode,
 				error,
 				error.node,

packages/cli/src/workflows/workflow-execution.service.ts

@@ -26,7 +26,7 @@ import {
 } from 'n8n-workflow';
 
 import { EventService } from '@/events/event.service';
-import { ExecutionDataService } from '@/executions/execution-data.service';
+import { FailedRunFactory } from '@/executions/failed-run-factory';
 import { SubworkflowPolicyChecker } from '@/executions/pre-execution-checks';
 import type { IWorkflowErrorData } from '@/interfaces';
 import { NodeTypes } from '@/node-types';
@@ -47,7 +47,7 @@ export class WorkflowExecutionService {
 		private readonly workflowRunner: WorkflowRunner,
 		private readonly globalConfig: GlobalConfig,
 		private readonly subworkflowPolicyChecker: SubworkflowPolicyChecker,
-		private readonly executionDataService: ExecutionDataService,
+		private readonly failedRunFactory: FailedRunFactory,
 		private readonly eventService: EventService,
 	) {}
 
@@ -342,7 +342,7 @@ export class WorkflowExecutionService {
 					);
 
 					// Create a fake execution and save it to DB.
-					const fakeExecution = this.executionDataService.generateFailedExecutionFromError(
+					const fakeExecution = this.failedRunFactory.generateFailedExecutionFromError(
 						'error',
 						errorWorkflowPermissionError,
 						initialNode,