feat: Allow skipping foreignkey constraint disablement for imports (n8n-io#25734)

Author: ahsanv

packages/cli/src/commands/import/__tests__/entities.test.ts

@@ -36,6 +36,7 @@ describe('ImportEntitiesCommand', () => {
 				false,
 				undefined,
 				false,
+				false,
 			);
 		});
 
@@ -61,6 +62,7 @@ describe('ImportEntitiesCommand', () => {
 				false,
 				undefined,
 				false,
+				false,
 			);
 		});
 
@@ -87,6 +89,7 @@ describe('ImportEntitiesCommand', () => {
 				true,
 				undefined,
 				false,
+				false,
 			);
 		});
 
@@ -112,6 +115,7 @@ describe('ImportEntitiesCommand', () => {
 				false,
 				'key.txt',
 				false,
+				false,
 			);
 		});
 
@@ -138,6 +142,34 @@ describe('ImportEntitiesCommand', () => {
 				false,
 				undefined,
 				true,
+				false,
+			);
+		});
+
+		it('should skip disabling foreign key constraints when skipTogglingForeignKeyConstraints flag is true', async () => {
+			const command = new ImportEntitiesCommand();
+			// @ts-expect-error Protected property
+			command.flags = {
+				inputDir: './outputs',
+				truncateTables: false,
+				skipTogglingForeignKeyConstraints: true,
+			};
+			// @ts-expect-error Protected property
+			command.logger = {
+				info: jest.fn(),
+				error: jest.fn(),
+			};
+
+			mockImportService.importEntities.mockResolvedValue(undefined);
+
+			await command.run();
+
+			expect(mockImportService.importEntities).toHaveBeenCalledWith(
+				'./outputs',
+				false,
+				undefined,
+				false,
+				true,
 			);
 		});
 
@@ -164,6 +196,7 @@ describe('ImportEntitiesCommand', () => {
 				false,
 				undefined,
 				false,
+				false,
 			);
 		});
 
@@ -190,6 +223,7 @@ describe('ImportEntitiesCommand', () => {
 				true,
 				undefined,
 				false,
+				false,
 			);
 		});
 	});

packages/cli/src/commands/import/entities.ts

@@ -20,6 +20,10 @@ const flagsSchema = z.object({
 		.boolean()
 		.describe('Skip migration validation checks')
 		.default(false),
+	skipTogglingForeignKeyConstraints: z.coerce
+		.boolean()
+		.describe('Skip disabling foreign key constraints')
+		.default(false),
 });
 
 @Command({
@@ -44,6 +48,7 @@ export class ImportEntitiesCommand extends BaseCommand<z.infer<typeof flagsSchem
 		const truncateTables = this.flags.truncateTables;
 		const keyFilePath = this.flags.keyFile ? safeJoinPath(this.flags.keyFile) : undefined;
 		const skipMigrationChecks = this.flags.skipMigrationChecks ?? false;
+		const skipTogglingForeignKeyConstraints = this.flags.skipTogglingForeignKeyConstraints ?? false;
 
 		this.logger.info('\n⚠️⚠️ This feature is currently under development. ⚠️⚠️');
 		this.logger.info('\n🚀 Starting entity import...');
@@ -52,12 +57,16 @@ export class ImportEntitiesCommand extends BaseCommand<z.infer<typeof flagsSchem
 		if (skipMigrationChecks) {
 			this.logger.info('⏭️  Skipping migration checks');
 		}
+		if (skipTogglingForeignKeyConstraints) {
+			this.logger.info('⏭️  Skipping disabling foreign key constraints');
+		}
 
 		await Container.get(ImportService).importEntities(
 			inputDir,
 			truncateTables,
 			keyFilePath,
 			skipMigrationChecks,
+			skipTogglingForeignKeyConstraints,
 		);
 	}
 

packages/cli/src/services/__tests__/import.service.test.ts

@@ -559,7 +559,7 @@ describe('ImportService', () => {
 			await importService.enableForeignKeyConstraints(mockEntityManager);
 
 			expect(mockEntityManager.query).toHaveBeenCalledWith(
-				'SET session_replication_role = DEFAULT;',
+				'SET session_replication_role = ORIGIN;',
 			);
 		});
 	});

packages/cli/src/services/import.service.ts

@@ -44,8 +44,8 @@ export class ImportService {
 			sqlite: 'PRAGMA defer_foreign_keys = OFF;',
 			'sqlite-pooled': 'PRAGMA defer_foreign_keys = OFF;',
 			'sqlite-memory': 'PRAGMA defer_foreign_keys = OFF;',
-			postgres: 'SET session_replication_role = DEFAULT;',
-			postgresql: 'SET session_replication_role = DEFAULT;',
+			postgres: 'SET session_replication_role = ORIGIN;',
+			postgresql: 'SET session_replication_role = ORIGIN;',
 		},
 	};
 
@@ -372,6 +372,7 @@ export class ImportService {
 		truncateTables: boolean,
 		keyFilePath?: string,
 		skipMigrationChecks = false,
+		skipTogglingForeignKeyConstraints = false,
 	) {
 		validateDbTypeForImportEntities(this.dataSource.options.type);
 
@@ -397,7 +398,9 @@ export class ImportService {
 		}
 
 		await this.dataSource.transaction(async (transactionManager: EntityManager) => {
-			await this.disableForeignKeyConstraints(transactionManager);
+			if (!skipTogglingForeignKeyConstraints) {
+				await this.disableForeignKeyConstraints(transactionManager);
+			}
 
 			// Get import metadata after migration validation
 			const importMetadata = await this.getImportMetadata(inputDir);
@@ -434,7 +437,9 @@ export class ImportService {
 				customEncryptionKey,
 			);
 
-			await this.enableForeignKeyConstraints(transactionManager);
+			if (!skipTogglingForeignKeyConstraints) {
+				await this.enableForeignKeyConstraints(transactionManager);
+			}
 		});
 
 		// Cleanup decompressed files after import