Testing/ca diagram#101
Closed
missionStrawberry wants to merge 13 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds unit tests covering the LearningMode page UI behavior (header presence and sidebar interactions) while mocking heavy diagram components.
Changes:
- Introduces
LearningModepage unit tests validating initial render state. - Tests sidebar behavior for open/close and node-click-driven content updates.
- Mocks
CADiagram(and attempts to mockLegend) to keep tests focused and fast.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
vivjd
approved these changes
Apr 22, 2026
vivjd
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! And thank you for adding the i18n config to main.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add test coverage (both end to end and unit) for learning mode and use case interaction diagram pages.
Proposed Changes
CADiagram.rendering.test.tsx,
CADiagram.interactivity.test.tsx,
CADiagram.status-and-states.test.tsx,
CADiagram.accessibility-and-resizeobserver.test.tsx,
testSetup.ts.
LearningMode.test.tsx,
UseCaseInteractionDiagram.test.tsx.
main.tsx,
index.tsx.
Also moved i18n import to main.
Closes #95
Closes #96
How to Test & Review
cd frontend
Run all unit tests
npm run test:unit -- --runRun CADiagram-focused unit tests
npm run test:unit -- tests/unit/components/CADiagram/CADiagram.rendering.test.tsx tests/unit/components/CADiagram/CADiagram.interactivity.test.tsx tests/unit/components/CADiagram/CADiagram.status-and-states.test.tsx tests/unit/components/CADiagram/CADiagram.accessibility-and-resizeobserver.test.tsx --runRun all E2E tests
npm run test:e2eRun only learning mode E2E
npm run test:e2e -- tests/e2e/learning-mode.spec.ts --project=chromiumRun only use-case interaction diagram E2E
npm run test:e2e -- tests/e2e/use-case-interaction-diagram.spec.ts --project=chromiumOpen Playwright UI mode
npm run test:e2e -- --uiType of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
I have performed a self-review of my changes.
I have added tests for my changes, if applicable.
I have updated the project documentation, if applicable.
(Frontend) I have added/updated text in
i18nJSON files for any new user-facing strings to support multilingual features.After opening your pull request:
I have verified that the CI tests have passed.
I have requested a review from a project maintainer, and a fellow student.
Technical Debt: If temporary workarounds or "TODOs" were used, I have opened a tracking issue to address them properly.
Questions and Comments